Re: [MoM] Packaging mindthegap (Was: [MoM] Packaging mindthemap)
Hi Shayan,
On Thu, Jul 11, 2019 at 07:48:21PM +0100, Shayan Doust wrote:
> > As an additional change: Please move /usr/share/mindthegap/test to
> > mindthegap-examples may be to the dir
>
> > /usr/share/doc/mindthegap/examples
>
> > (or something like this) and adapt the test to this. I'm also
> > wondering about the role of the data files in the dir data. Are
> > these just examples as well or are these expected by mindthegap
> > executable when running. If its the former these should also go
> > into the examples package.
>
> By "are these expected by mindthegap executable when running": Do you
> mean whether or not they are used within a general runtime for any
> command invoked by the user, as they are not.
Yes, that's what I mean. Assume a user wants to analyse own data.
Would this be possible without the files currently installed to
/usr/share/mindthegap/data
If the answer is yes, the files should rather go to mindthegap-examples.
We want production packages with a minimum set of files that is needed
for production. Anything else should go to some doc / contrib / example
package (whatever name we might pick).
Assuming that this is the case all data should be carried in the package
mindthegap-examples and there is IMHO the most visible directory
/usr/share/doc/mindthegap
^^^
Users **should** lock into /usr/share/doc/PACKAGE - I know that this is
hidden knowledge in practice but at least it is documented that all user
oriented documentation and files that are helping the user to understand
how to use the actual package can be found in /usr/share/doc. Users
are not supposed to look into /usr/share/PACKAGE since there is rather
technical stuff.
The additional advantage to move the architecture independent files out
of the package mindthegap is that the architecture dependant package
will cary mostly architecture dependant files. That's helpful for the
mirror network since the data will be stored only once and not multiple
times per architecture.
> I now assume you meant
> whether or not they are there solely as static reference or if they are
> ever read and handled. Yes, they are read and handled by the test
> scripts only, so I assume now I should just keep it where they
> originally were and just keep test within the new path you specified?
I think we now agree that all data can go to
/usr/share/doc/mindthegap/examples
and the run-unit-tests script is adapted to that location. However, you
probably realised that the test is failing now. I checked this and one
feature of dh_compress (which is called by dh - see dh_compress(1)) to
compress files in /usr/share/doc if these exceed a certain limit. This
means, before our test suite can deal with these data they need to be in
the form as they were before (most files uncompressed but there is one
compressed file expected (data/contig-reads.fasta.gz) to let all tests
pass. I included this decompression procedure in my last commit.
> Sorry about the confusion,
No need to sorry. Its a feature of MoM that you can ask simple
questions and make wrong assumptions etc. That's fine and I think we
now sorted out everything. Thus I uploaded your package to new.
Congratulations to your first Debian package!
BTW, depending how picky you are you might like to contact upstream
about
I: mindthegap: spelling-error-in-binary usr/bin/MindTheGap writting writing
I have no idea how this is perceived. Sometimes I'm in the mood to fix
even this - now idea about you (but its definitely no show stopper for
an upload to new and thus I ignored this).
I'm really happy that you managed in less than 10 days. Pretty good!
If you are interested in continue packaging something that might be
in your interest I'd happily support this.
Kind regards and thanks for your work
Andreas.
--
http://fam-tille.de
Reply to: