[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [MoM] Packaging mindthegap (Was: [MoM] Packaging mindthemap)



Hi again,

I may have misread your email.


> As an additional change:  Please move /usr/share/mindthegap/test to
> mindthegap-examples may be to the dir

>   /usr/share/doc/mindthegap/examples

> (or something like this) and adapt the test to this.  I'm also
> wondering about the role of the data files in the dir data.  Are
> these just examples as well or are these expected by mindthegap
> executable when running.  If its the former these should also go
> into the examples package.

By "are these expected by mindthegap executable when running": Do you
mean whether or not they are used within a general runtime for any
command invoked by the user, as they are not. I now assume you meant
whether or not they are there solely as static reference or if they are
ever read and handled. Yes, they are read and handled by the test
scripts only, so I assume now I should just keep it where they
originally were and just keep test within the new path you specified?

Sorry about the confusion,
Shayan Doust

On 11/07/2019 09:53, Andreas Tille wrote:
> Hi again,
> 
> I have some comments here and further additions.
> 
> On Thu, Jul 11, 2019 at 09:23:54AM +0300, merkys@debian.org wrote:
>> Hi Shayan,
>>
>> On 2019-07-10 18:59, Shayan Doust wrote:
>>> I will review over the recent emails transacted by you so I can see if I
>>> have missed out anything - hopefully I haven't as I have the slight
>>> tendancy of skimming over things :-). I will again push everything as
>>> soon as possible.
>>
>> Just minor things (as of GIT commit
>> e24d2fa2bf1113a7984b53ffaae8dae384cb8c0f):
>>
>> 1. debian/lintian-overrides is empty, thus should be removed;
> 
> Yes.  This template only exists for cases when we leave language
> extensions which is admitedly really ugly but decided by the team.
> Its not needed here and thus should be deleted.
> 
>> 2. debian/README.test is trivial, I suggest removing it;
> 
> Hmmm, no.  I'd rather prefer to add debian/mindthegap-examples.docs
> containing
> 
> debian/README.test
> debian/tests/run-unit-test
> 
> 
> This is what we use to provide the user with executable examples.
> However, also the scripts need to be provided in mindthegap-examples
> to let the user really reproduce on the local machine what can be
> tested.
>  
>> 3. explicit depends on libgatbcore2 is not needed for mindthegap:
>> dh_shlibdeps puts in versioned dependency;
> 
> +1
>  
>> 4. I suppose ${shlibs:Depends} are irrelevant for Architecture: all
>> packages;
> 
> See my commits.
>  
>> 5. IMO having Jenkins release/build scripts in -examples package is of
>> little use for Debian users;
> 
> +1
>  
>> 6. a comma is missing between ${python3:Depends} and mindthegap in
>> Depends: line of mindthegap-examples;
> 
> +1 - but see my commits.
>  
>> 7. I'd replace ${python3:Depends} with python3 in Depends: line of
>> mindthegap-examples, the former is empty;
> 
> I agree that this is probably better than my way to add
> 
>                dh-python,
>                dh-sequence-python3,
> 
> to Build-Depends and " --with python3" to the dh call in d/rules.
> It also ends up empty - so python3 is the better choice here.
>  
>> 8. Python packages used in example scripts should appear on Depends:
>> line. I guess this has to be done manually;
> 
> Which ones do you have in mind here?
> 
>> 9. debian/rules contains a lot of commented template code, I suggest
>> cleaning that up.
> 
> +1 - see my commits
>  
> 
> I was lazy enough to simply do the actual changes and add according
> comments to the commits.  Please have a look.
> 
> As an additional change:  Please move /usr/share/mindthegap/test to
> mindthegap-examples may be to the dir
> 
>    /usr/share/doc/mindthegap/examples
> 
> (or something like this) and adapt the test to this.  I'm also
> wondering about the role of the data files in the dir data.  Are
> these just examples as well or are these expected by mindthegap
> executable when running.  If its the former these should also go
> into the examples package.
> 
> Kind regards
> 
>       Andreas.
> 


Reply to: