Re: [MoM] Packaging mindthegap (Was: [MoM] Packaging mindthemap)

[merkys@debian.org]

Hi Shayan,

On 2019-07-10 18:59, Shayan Doust wrote:
> I will review over the recent emails transacted by you so I can see if I
> have missed out anything - hopefully I haven't as I have the slight
> tendancy of skimming over things :-). I will again push everything as
> soon as possible.

Just minor things (as of GIT commit
e24d2fa2bf1113a7984b53ffaae8dae384cb8c0f):

1. debian/lintian-overrides is empty, thus should be removed;

2. debian/README.test is trivial, I suggest removing it;

3. explicit depends on libgatbcore2 is not needed for mindthegap:
dh_shlibdeps puts in versioned dependency;

4. I suppose ${shlibs:Depends} are irrelevant for Architecture: all
packages;

5. IMO having Jenkins release/build scripts in -examples package is of
little use for Debian users;

6. a comma is missing between ${python3:Depends} and mindthegap in
Depends: line of mindthegap-examples;

7. I'd replace ${python3:Depends} with python3 in Depends: line of
mindthegap-examples, the former is empty;

8. Python packages used in example scripts should appear on Depends:
line. I guess this has to be done manually;

9. debian/rules contains a lot of commented template code, I suggest
cleaning that up.

Let me know if you have any questions,
Andrius