Re: VistA packaging : vista-foia : First review
Hi Luis,
many thanks for your great debugging job!
On Sun, Feb 02, 2014 at 09:51:00PM -0500, Luis Ibanez wrote:
> ...
>
> What do we do ?
> =============
>
>
> I could generated the delta with xdelta3 and populate the
> pristine-tar branch, but, it is unclear whether this will do
> any good if the other systems that will attempt to build
> the package are still using xdelta 1.1.3.
Did you noticed
$ LANG=C apt-cache search xdelta | grep ^x
xdelta - A diff utility which works with binary files
xdelta3 - Diff utility which works with binary files
... so probably there would have been a shortcut from installing xdelta3
from upstream source - but again ... thanks for your intense work on
this!
> Suggestion A:
> ===========
>
> From reading the gbp.conf man page:
> http://honk.sigxcpu.org/projects/git-buildpackage/manual-html/gbp.cfgfile.html
>
> It seems that we could put a customized gbp.conf file in this specific
> repository, by placing it in:
>
> debian/gbp.conf : per repository/branch configuration
>
> To change the default behavior and exclude the use of pristine-tar
> (and hence the downstream use of xdelta), by using the setting:
I'm about to travel and thus I can not check: Is there any option to
use the (packaged) xdelta3 instead of xdelta?
> [DEFAULT]
> pristine-tar = False
Admittedly I would not like this.
> The justification would be that:
>
> xdelta 1.1.3 in sid, has limitation to files smaller than 2Gb,
>
> and our tar file is 2.9Gb
>
>
>
> Suggestion B:
> ===========
>
>
> Another option would be to change "pristine-tar" to not use the line 545:
>
> my $ret=system("$xdelta_program delta -0 --pristine $recreatetarball
> $tarball $delta{delta}")
>
> but use instead:
>
> my $ret=system("$xdelta_program delta -9 --pristine $recreatetarball
> $tarball $delta{delta}")
>
> (or something along those lines) to trigger the use of compression,
> and to make it compare tar files in their compressed form, instead
> of their uncompressed one.
>
> This probably would have to be brought to the maintainers of pristine-tar...
We should in any case report the result of your analyses to the
maintainers of pristine-tar. Please file a bug report against xdelta
by either including your analysis or linking to your analysis mail in
the archive of the mailing list. (Please check before BTS if this is
a known problem).
In addition you could file a bug to pristine-tar maintainers to use
xdelta3 instead of xdelta to avoid the problem you reported in
#<bugnumber>.
Considering that some other packages are affected:
$ apt-cache rdepends xdelta
xdelta
Reverse Depends:
debdelta
pristine-tar
vzdump
syncmaildir
the maintainers might (or might not?) be kept in the row as well.
> I'm probably missing other good alternatives.
You missed the obvious one to file a bug report. ;-)
> Will appreciate any guidance and advice on how to move forward,
Again: Thanks a lot for your intense work on this
Andreas
--
http://fam-tille.de
Reply to: