Re: VistA packaging : vista-foia : First review

On Sun, Feb 2, 2014 at 10:43 AM, Andreas Tille <andreas@an3as.eu> wrote:

Hi Luis,

On Sun, Feb 02, 2014 at 09:46:40AM -0500, Luis Ibanez wrote:
> $ TMPDIR=/var/tmp git import-orig --pristine-tar
> ../../Replication/vista-foia_0.20130405.orig.tar.gz
>
> What is the upstream version? [0.20130405]
> gbp:info: Importing '../../Replication/vista-foia_0.20130405.orig.tar.gz'
> to branch 'upstream'...
> gbp:info: Source package is vista-foia
> gbp:info: Upstream version is 0.20130405
> xdelta: warning: no matches found in from file, patch will apply without it
> error: excessively large binary delta for
> /var/tmp/pristine-tar.bC1wZJOkad/origtarball

To make sure git-buildpackage is not simply lying: Could you check out
the upstream branch and unpack the original tarball to some other place
and do some

diff -ubrN <repository> <unpackaged_tarball>

(perhaps you need to move the .git dir to somewhere else before doing
this). This would uncover whether there might be real differences and
your import is somehow broken.

Andreas,

Thanks for suggesting this test.

It seems to clarify that the upstream branch and the tar file

have identical content.

Here is what I just did:

$ git branch

* master

upstream

$ git checkout upstream

Switched to branch 'upstream'

Your branch is ahead of 'origin/upstream' by 3 commits.

(use "git push" to publish your local commits)

$ git branch

master

* upstream

$ mv .git/ ..

$ cd ..

$ ls

vista-foia

$ ls -a

. .. .git vista-foia

$ tar -xzf ../Replication/vista-foia_0.20130405.orig.tar.gz

$ ls -a

. .. .git vista-foia vista-foia-0.20130405

$ diff -ubrN vista-foia vista-foia-0.20130405/

and came out silent (no diffs found).

Just as a sanity check:

$ ls vista-foia

BUILD-Delphi.rst CMakeLists.txt DocGen LICENSE OSEHRA-VistA-M-897bff2 Packages.csv README.rst Testing

CMake CTestConfig.cmake Documentation NOTICE Packages Python Scripts Utilities

$ ls vista-foia-0.20130405/

BUILD-Delphi.rst CMakeLists.txt DocGen LICENSE OSEHRA-VistA-M-897bff2 Packages.csv README.rst Testing

CMake CTestConfig.cmake Documentation NOTICE Packages Python Scripts Utilities

$ du -hs vista-foia

2.8G vista-foia

$ du -hs vista-foia-0.20130405/

2.8G vista-foia-0.20130405/

I'll follow now your suggestion of recreating the repository

from scratch, using a better compression for the tar file.

Thanks

Luis