[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://rtpg/{rtpg-www.templates}



Please find, for review, the debconf templates and packages descriptions for the rtpg source package.

This review will last from Friday, December 26, 2008 to Monday, January 05, 2009.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:
--- ../rtpg.old/debian/rtpg-www.templates	2008-12-25 15:00:26.816053105 +0100
+++ debian/rtpg-www.templates	2008-12-26 08:20:06.200052941 +0100
@@ -1,9 +1,10 @@
 Template: rtpg-www/change_host
 Type: boolean
 Default: true
-_Description: Do You agree to add the record to /etc/hosts?
- This package is supplied with a variant of an adopted
- virtual server for apache. However for this variant it is
- needed to add a record into  hosts. This tuning script can
- do it automatically.
+_Description: Add an entry for the virtual server in /etc/hosts?
+ This package may define a virtual server in Apache's configuration.
+ .
+ For this to be fully functional, it is needed to add an entry
+ for the virtual server in the /etc/hosts file. This operation
+ can be done automatically if you choose this option.

Make the template clearer.

Split in two paragraphs for readability.

 
--- ../rtpg.old/debian/control	2008-12-25 15:00:26.816053105 +0100
+++ debian/control	2008-12-26 08:21:10.956052713 +0100
@@ -10,7 +10,5 @@
 Depends: librpc-xml-perl, libjson-xs-perl, libjs-jquery, libtemplate-perl,
  rtorrent (>= 0.7.9), apache2, debconf, libapache2-mod-scgi
 Description: web based front end for rTorrent
- RTPG (rtorrent perl gui) is a simple GUI web for rtorrent. It allows to
- scan/delete/add torrents and also to set the priority to the certain
- torrents or their parts.
-
+ RTPG (rtorrent perl gui) is a simple web interface for rtorrent. It allows
+ to scan/delete/add torrents and set their respective priorities.

I'm not sure I understand the last part of the sentence but I'm fairly
sure it needed to be rewritten..:-)

I hope that my proposed simplification does not betray the advertized
functionality.


-- 


Template: rtpg-www/change_host
Type: boolean
Default: true
_Description: Add an entry for the virtual server in /etc/hosts?
 This package may define a virtual server in Apache's configuration.
 .
 For this to be fully functional, it is needed to add an entry
 for the virtual server in the /etc/hosts file. This operation
 can be done automatically if you choose this option.

--- ../rtpg.old/debian/rtpg-www.templates	2008-12-25 15:00:26.816053105 +0100
+++ debian/rtpg-www.templates	2008-12-26 08:20:06.200052941 +0100
@@ -1,9 +1,10 @@
 Template: rtpg-www/change_host
 Type: boolean
 Default: true
-_Description: Do You agree to add the record to /etc/hosts?
- This package is supplied with a variant of an adopted
- virtual server for apache. However for this variant it is
- needed to add a record into  hosts. This tuning script can
- do it automatically.
+_Description: Add an entry for the virtual server in /etc/hosts?
+ This package may define a virtual server in Apache's configuration.
+ .
+ For this to be fully functional, it is needed to add an entry
+ for the virtual server in the /etc/hosts file. This operation
+ can be done automatically if you choose this option.
 
--- ../rtpg.old/debian/control	2008-12-25 15:00:26.816053105 +0100
+++ debian/control	2008-12-26 08:21:10.956052713 +0100
@@ -10,7 +10,5 @@
 Depends: librpc-xml-perl, libjson-xs-perl, libjs-jquery, libtemplate-perl,
  rtorrent (>= 0.7.9), apache2, debconf, libapache2-mod-scgi
 Description: web based front end for rTorrent
- RTPG (rtorrent perl gui) is a simple GUI web for rtorrent. It allows to
- scan/delete/add torrents and also to set the priority to the certain
- torrents or their parts.
-
+ RTPG (rtorrent perl gui) is a simple web interface for rtorrent. It allows
+ to scan/delete/add torrents and set their respective priorities.
Source: rtpg
Maintainer: Dmitry E. Oboukhov <unera@debian.org>
Section: web
Priority: optional
Build-Depends: cdbs, debhelper, po-debconf
Standards-Version: 3.8.0

Package: rtpg-www
Architecture: all
Depends: librpc-xml-perl, libjson-xs-perl, libjs-jquery, libtemplate-perl,
 rtorrent (>= 0.7.9), apache2, debconf, libapache2-mod-scgi
Description: web based front end for rTorrent
 RTPG (rtorrent perl gui) is a simple web interface for rtorrent. It allows
 to scan/delete/add torrents and set their respective priorities.

Attachment: signature.asc
Description: Digital signature


Reply to: