[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://rtpg/{rtpg-www.templates}



Christian Perrier wrote:
> Your review should be sent as an answer to this mail.

You managed to catch me away from keyboard!

> -_Description: Do You agree to add the record to /etc/hosts?
> - This package is supplied with a variant of an adopted
> - virtual server for apache. However for this variant it is
> - needed to add a record into  hosts. This tuning script can
> - do it automatically.
> +_Description: Add an entry for the virtual server in /etc/hosts?
> + This package may define a virtual server in Apache's configuration.
> + .
> + For this to be fully functional, it is needed to add an entry
> + for the virtual server in the /etc/hosts file. This operation
> + can be done automatically if you choose this option.

No, that doesn't work with "needed".  "Necessary" would be the quick
fix, but more natural:

    For this to be fully functional, the virtual server needs an entry
    added in the /etc/hosts file. This operation can be performed
    automatically if you choose this option.

>  Description: web based front end for rTorrent
> - RTPG (rtorrent perl gui) is a simple GUI web for rtorrent. It allows to
> - scan/delete/add torrents and also to set the priority to the certain
> - torrents or their parts.
> -
> + RTPG (rtorrent perl gui) is a simple web interface for rtorrent. It allows
> + to scan/delete/add torrents and set their respective priorities.

"rtorrent perl gui"?  (/usr/bin/)rtorrent and (/usr/bin/)perl have
some right to all-lower-case, but "gui" is stretching it.  Then
again... rTorrent Perl GUI?  RTorrent Perl Gui?  Okay, I'll leave it
as it is.

Then "allow" without an object, that old debian-l10n-english fave.
Again, switch it around as if the torrent _wanted_ to be scanned;
crazy, really, but that's the natural idiom...

The best way of using "respectively" is almost always not to.

    RTPG (rtorrent perl gui) is a simple web interface for rtorrent. It allows
    torrents to be scanned, added, deleted, and assigned priorities.
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
--- ../rtpg.old/debian/rtpg-www.templates	2008-12-26 07:26:28.000000000 +0000
+++ debian/rtpg-www.templates	2008-12-27 18:35:46.000000000 +0000
@@ -4,7 +4,6 @@
 _Description: Add an entry for the virtual server in /etc/hosts?
  This package may define a virtual server in Apache's configuration.
  .
- For this to be fully functional, it is needed to add an entry
- for the virtual server in the /etc/hosts file. This operation
- can be done automatically if you choose this option.
-
+ For this to be fully functional, the virtual server needs an entry
+ added in the /etc/hosts file. This operation can be performed
+ automatically if you choose this option.
--- ../rtpg.old/debian/control	2008-12-26 07:26:28.000000000 +0000
+++ debian/control	2008-12-27 18:34:41.000000000 +0000
@@ -11,4 +11,4 @@
  rtorrent (>= 0.7.9), apache2, debconf, libapache2-mod-scgi
 Description: web based front end for rTorrent
  RTPG (rtorrent perl gui) is a simple web interface for rtorrent. It allows
- to scan/delete/add torrents and set their respective priorities.
+ torrents to be scanned, added, deleted, and assigned priorities.
Template: rtpg-www/change_host
Type: boolean
Default: true
_Description: Add an entry for the virtual server in /etc/hosts?
 This package may define a virtual server in Apache's configuration.
 .
 For this to be fully functional, the virtual server needs an entry
 added in the /etc/hosts file. This operation can be performed
 automatically if you choose this option.
Source: rtpg
Maintainer: Dmitry E. Oboukhov <unera@debian.org>
Section: web
Priority: optional
Build-Depends: cdbs, debhelper, po-debconf
Standards-Version: 3.8.0

Package: rtpg-www
Architecture: all
Depends: librpc-xml-perl, libjson-xs-perl, libjs-jquery, libtemplate-perl,
 rtorrent (>= 0.7.9), apache2, debconf, libapache2-mod-scgi
Description: web based front end for rTorrent
 RTPG (rtorrent perl gui) is a simple web interface for rtorrent. It allows
 torrents to be scanned, added, deleted, and assigned priorities.

Reply to: