Re: Bouncy Castle ready

[Wolfgang Baer <WBaer@gmx.de>]

Hi Charles,

Charles Fry wrote:
> > Please add as much details as you have now to the bug database
> > http://www.gnu.org/software/classpath/bugs.html
> > That way the issue isn't forgotten. You can always later add more
> > details if you have more time. Just make sure the instructions on how to
> > repeat the issue are clear and simple to follow so someone else can try
> > to reproduce it.
>
>
> I went to file a bug, and was prompted to specify which version of
> classpath this applied to. The choices started at .15, and I then
> checked and found that .14 is the most recent version available in
> Debian.
>
> I'd like to test this bug against .17, but was hoping to avoid spending
> a lot of time doing so. What are the prospects of getting .17 into
> Debian?

I tried to test against the current classpath and kaffe CVS however it
seems you didn't enable the whole testsuite in the build ? The single
regression test during build fails for me also with a JDK 1.4 with:

making TSP release
compiling
java.security.NoSuchProviderException: JCE cannot authenticate the provider BC
        at javax.crypto.SunJCE_b.a(DashoA6275)
        at javax.crypto.SunJCE_b.a(DashoA6275)
        at javax.crypto.KeyGenerator.getInstance(DashoA6275)
        at org.bouncycastle.tsp.test.TSPTestUtil.<clinit>(TSPTestUtil.java:57)
        at org.bouncycastle.tsp.test.TSPTest.perform(TSPTest.java:49)
        at org.bouncycastle.tsp.test.RegressionTest.main(RegressionTest.java:23)
Caused by: java.util.jar.JarException: 
file:/home/wbaer/privat/Debian-GIS/test/bouncycastle-1.29/bcprov-jdk14-0.jar 
has unsigned entries - org/bouncycastle/asn1/x509/V3TBSCertificateGenerator.class
        at javax.crypto.SunJCE_d.b(DashoA6275)
        at javax.crypto.SunJCE_d.a(DashoA6275)
        at javax.crypto.SunJCE_d.a(DashoA6275)
        at javax.crypto.SunJCE_b.b(DashoA6275)
        ... 6 more
TSPTest: Exception - java.lang.NullPointerException
ParseTest: Okay

With free vms I only get the NPE for TSPTest. I couldn't found other tests.

Some general review comments:

debian/control
- please depends on sablevm | java1-runtime | java2-runtime so that also the
  other free runtimes can be used and not just sablevm
- you build-dep on free-java-sdk ... but apparently build it with an JDK in
  /opt/.... ?

debian/rules
- this is an arch-indep package so you should do the stuff in the arch-indep
  targets and not in the arch targets

the build1-4 file
- you (or upstream) uses not direct calls to javadoc, javac and java via
  the PATH variable, which will be prepended with the JDK-Path given at the
  top of the build file. Like:

  PATH=$JDK14PATH/bin:$PATH
  export PATH

  java ....

  This is not a reproducable setup - for example in my case as I don't have
  anything under /opt my current javac in the path was used. You should use
  explicit calls to the programs instead:

  $JDK14PATH/bin/java


orig.tar.gz:
Please repackage the orig.tar.gz file before an upload to the official
debian archive. 12 MB is a way to much and it also contains license problems.
e.g. delete the complete prebuilt jars in the jars dir (that 10 MB !)
and also the files in the zips directory - these are containing sun precompiled
classes which we have no source code for !!

general:
I personally would like to see a doc package for the javadocs. The
documentation is 20 MB uncompressed. I think this justifies an own package.


If you could enable the complete testsuite during build time I would run
it against the current classpath and kaffe cvs version so we can really
report the current problems with free vms.

Hope this helps,

Wolfgang