[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: libpsm2



Hi Mehdi,

On Wed, Dec 20, 2017 at 5:31 PM, Mehdi Dogguy <mehdi@dogguy.org> wrote:
> Hi Brian,
>
> On 08/12/2017 20:15, Brian Smith wrote:
>>     libpsm2-2-compat - Preload library to provide PSM2 support for PSM
>>         applications
>>
>
> Wouldn't it be better if this shared library is handled using alternatives?
>
> This will allow a user to take advantage of this library without the need
> to fiddle with environment variables and makes its deployment even more
> easier.
>
> My proposal is implemented in the patch attached. I've used this on an HPC
> cluster and found it neat. It we agree on this, I can add it to infinipath-psm
> package as well.

I'll take a look at testing the alternatives patch you provided.

>
> Besides, libpsm2-2 and libpsm2-2-compat provide udev rules but do not call
> "udevadm control --reload-rules >/dev/null 2>&1" in postinst.
>
> Is udev auto-detecting new rules now?


libpsm2-2's 40-psm.rules sets the permissions for the hfi1 devices to
0666. This appears to be unnecessary, as the hfi1 module now has code
to set the 0666 permission in the hfi1_devnode callback. Therefore, I
believe that 40-psm.rules should be removed from libpsm2-2.

40-psm-compat.rules creates the /dev/ipath symlink, so it is still
needed by libpsm2-2-compat. I will take a look at that in concert with
testing the alternatives patch.

>
> Cheers,
>
> --
> Mehdi


Reply to: