[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFS] golang-step-cli-utils






Am 11. August 2021 20:01:17 MESZ schrieb Nilesh Patra <nilesh@nileshpatra.info>:


On 8/11/21 8:50 PM, Peymaneh Nejad wrote:
I have downgraded the package to 0.2.0 and pushed to salsa. I also took the liberty to delete the debian/0.4.0 to avoid confusion in case v0.4.0 should be uploaded at later point.

Also, both these packages have dependencies embedded in pkg/*
golang-step-cli-utils has blackfriday there, which is already in
archive. Whilst I uploaded for now, but IMO these should really be repacked and package should be used from
archive during subsequent uploads.

Source is now repacked and builds with blackfriday/v2 from archives :)

Awesome. There should be similar removing test-only deps and annotating corresponding B-D with nocheck - I did this now.

Thanks!

However, I noticed that there are B-D and Depends on

golang-gopkg-yaml.v2-dev
golang-github-shurcool-sanitized-anchor-name-dev

Are they really needed?

You're right, they are not.
I had only checked for diff when downgrading, but these are actually, unrelated to that, indirect dependencies, partly from the vendored blackfriday package that I have excluded.
I have pushed a -2 version for future source only upload

Peymaneh

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


Reply to: