Re: Help for packaging shfmt
On 10/02/2021 18:23, Faustin Lammler wrote:
Aloïs Micard <alois@micard.lu>,
10/02/2021 – 17:53:49 (+0100):
I'll ask an owner of the go-team to grants you access to your repository,
then we can review it & check what's going on :)
I have just pushed it.
Thanks !
Your packaging looks pretty good!
Here's a little review:
- debian/changelog:
* Initial release NMU (Closes: 982472)
You do not need to add 'NMU', as your are an uploader of the package,
you aren't doing an NMU, so just remove the 'NMU' mention. :)
The Closes keyword need to be formatted like this: (Closes: #nnnn)
so add an # before the bug number.
debian/control:
- Section: devel
Can you change from devel to golang?
we have our section now.
- Standards-Version: 4.5.0
Can you bump to 4.5.1 ? It's the latest one.
see: https://www.debian.org/doc/debian-policy/
- Description
The description field is malformed, see:
https://www.debian.org/doc/debian-policy/ch-controlfields.html#description
basically you'll want to have a synopsis on the first line, and an extended
description on the other lines, something like (only a suggestion):
```
Description: go library used to create, modify, and print diffs
The top level package, diff, contains convenience functions for the most common uses.
.
The subpackages provide very fine-grained control over every aspect:
.
- myers creates diffs using the Myers diff algorithm.
- edit contains the core diff data types.
- ctxt provides tools to reduce the amount of context in a diff.
- write provides routines to write diffs in standard formats.
```
- debian/copyright:
- Copyright: Copyright 2018 Joshua Bleecher Snyder
I think you should format it like:
Copyright: 2018 Joshua Bleecher Snyder <josharian+github@gmail.com>
Cheers!
--
Aloïs Micard (creekorful) <alois@micard.lu>
GPG: DA4A A436 9BFA E299 67CD E85B F733 E871 0859 FCD2
Reply to: