Re: upgrade orfeotoolbox to 5.0

Hello,

I had pushed some modifications:

otb-apps: all applications .so are moved into this package

libotb-commandline: shared library for commandline launcher

libotb-common: this package is renamed to libotb-commandline
libotb-qt4: shared library for OTBApplicationLauncher Qt

Add man pages for all otb applications. I had kept the .1 files in debian/manpages/.

Regarding symbol files, I decided not to create it right now as Russ Albery's himself mentioned that it may not be worth for large libraries with heavy usage of templates. Also OTB has version prefix in .so files which is another reason pointed out by Russ to not use symbol files.

But I will try to experiment this feature and if the output symbol file is helpful, I add to debian package.

Regarding missing ITCopyright, the issue was resolved upstream.

https://bugs.orfeo-toolbox.org/view.php?id=1074

Could I include that patch in the current packaging or wait for next release ?

Can you confirm if the package is ready for experimental?

On Fri, Sep 11, 2015 at 10:11 AM, Rashad M <mohammedrashadkm@gmail.com> wrote:

Hello Bas,

I have moved the files in ITCopyright section under GETCopyright. Also I updated the comment about ITK headers in ThirdParty/ITK/include.

On Thu, Sep 10, 2015 at 4:13 PM, sebastic <sebastic@xs4all.nl> wrote:
On 2015-09-10 15:14, Rashad M wrote:

On Fri, Sep 4, 2015 at 11:31 PM, Sebastiaan Couwenberg wrote:

On 04-09-15 19:29, Rashad M wrote:
> On Fri, Sep 4, 2015 at 6:36 PM, Sebastiaan Couwenberg wrote:
>> On 04-09-15 16:11, Rashad M wrote:
>>> FYI, svn trunk now shows MIT license -
>>> http://svn.osgeo.org/ossim/trunk/ossim/LICENSE.txt
>>
>> Are the more details about the OTB license change elsewhere?
>>
>
> sorry. I wasn't clear before. the change of above license was for OSSIM
not
> OTB. I noted because currently Modules/ThirdParty/OssimPlugins/src/ossim
is
> using upstream license with an indication that full license text will be
> found in LICENSE.txt file. Since next release of ossim this will ve
changed
> and maybe the files in Modules/ThirdParty/OssimPlugins/src/ossim

Yes, I misread the ossim/otb bit.

> But there has been on going work on moving OTB license to Apache 2.0! .

That's cool too :-)

>>> I can include this detail in the comment section. would that be
>> sufficient?
>>
>> A comment for the ITK derived files is an option, but not strictly
>> required.
>>
>> The Comment or Source field in the copyright header does still need to
>> document why 6S and SuperBuild are excluded.
>>
>
> I will add that. Exclusion of 6S sources are discussed in list beofre.
So
> I am not copy pasting here. For SuperBuild, there are patches directory
in
> SuperBuild/patches which contains some specific patch for dependencies.
> currently it is a mix and excluding superbuild completely seems an easy
> pick.
>
> As you said, I will include this information in copyright.
>
> Thanks again for reviewing OTB.

I've pushed some more license & copyright changes, the copyright files
is nearly done. I've added two TODOs that still need some work. The
first is for the explanation for the repacking, the other is for the
missing ITCopyright.txt that is used for quite a number of files. I
didn't find the ITCopyright.txt in the otb git repository history, it
may never have been included. Since the files are licensed under the
CeCILL-2.0 if the ITCopyright.txt cannot be found the separate Files
section can be merged in the general Files: * section.

I had checked about ITCopyright with the team and this file is in OTB
under the name GETCopyright.txt in OTB/Copyright directory.

Is it possible to mention this in debain/copyright? For future releases I
will push the fix onto upstream.

The GETCopyright is already documented in the copyright, see:

http://anonscm.debian.org/cgit/pkg-grass/otb.git/tree/debian/copyright#n81

The separate Files section for the ITCopyright files can be merged into that section.

Kind Regards,

Bas

--
Regards,
Rashad

Regards,
Rashad