Re: upgrade orfeotoolbox to 5.0

I had fixed the errors and some warnings from linitan.

Below is what remaining. Could you have a look at sometime?

still there is file-without-copyright-information for SuperBuild even if that is excluded.

dpkg-buildpackage: full upload (original source is included)
Now running lintian...
W: otb source: missing-field-in-dep5-copyright license (paragraph at line 10)
W: otb source: missing-field-in-dep5-copyright copyright (paragraph at line 10)
W: otb source: ambiguous-paragraph-in-dep5-copyright paragraph at line 18
W: otb source: missing-license-text-in-dep5-copyright CeCILL (paragraph at line 18)
W: otb source: file-without-copyright-information .hg_archival.txt
W: otb source: file-without-copyright-information .hgignore
W: otb source: file-without-copyright-information .hgsigs
W: otb source: file-without-copyright-information .hgtags
W: otb source: file-without-copyright-information LICENSE
W: otb source: file-without-copyright-information README
W: otb source: file-without-copyright-information RELEASE_NOTES.txt
W: otb source: file-without-copyright-information SuperBuild/CMake/External_boost.cmake
W: otb source: file-without-copyright-information SuperBuild/CMake/External_curl.cmake
W: otb source: file-without-copyright-information SuperBuild/CMake/External_expat.cmake
W: otb source: file-without-copyright-information SuperBuild/CMake/External_fftw.cmake
W: otb source: file-without-copyright-information SuperBuild/CMake/External_gdal.cmake
W: otb source: file-without-copyright-information SuperBuild/CMake/External_geos.cmake
W: otb source: file-without-copyright-information SuperBuild/CMake/External_geotiff.cmake
W: otb source: file-without-copyright-information SuperBuild/CMake/External_itk.cmake
W: otb source: file-without-copyright-information SuperBuild/CMake/External_jpeg.cmake
W: otb source: file-without-copyright-information SuperBuild/CMake/External_libkml.cmake
W: otb source: file-without-copyright-information SuperBuild/CMake/External_libsvm.cmake
W: otb source: file-without-copyright-information SuperBuild/CMake/External_muparser.cmake
W: otb source: file-without-copyright-information SuperBuild/CMake/External_muparserx.cmake
W: otb source: file-without-copyright-information SuperBuild/CMake/External_opencv.cmake
W: otb source: file-without-copyright-information SuperBuild/CMake/External_openjpeg.cmake
W: otb source: file-without-copyright-information SuperBuild/CMake/External_openthreads.cmake
W: otb source: file-without-copyright-information SuperBuild/CMake/External_ossim.cmake
W: otb source: file-without-copyright-information SuperBuild/CMake/External_otb.cmake
W: otb source: file-without-copyright-information SuperBuild/CMake/External_pcre.cmake
W: otb source: file-without-copyright-information SuperBuild/CMake/External_png.cmake
W: otb source: file-without-copyright-information SuperBuild/CMake/External_proj.cmake
W: otb source: file-without-copyright-information SuperBuild/CMake/External_qt4.cmake
W: otb source: file-without-copyright-information SuperBuild/CMake/External_sqlite.cmake
W: otb source: file-without-copyright-information SuperBuild/CMake/External_swig.cmake
W: otb source: file-without-copyright-information SuperBuild/CMake/External_tiff.cmake
W: otb source: file-without-copyright-information SuperBuild/CMake/External_tinyxml.cmake
W: otb source: file-without-copyright-information SuperBuild/CMake/External_zlib.cmake
W: otb source: file-without-copyright-information SuperBuild/CMake/SuperBuild_Macro.cmake
W: otb source: file-without-copyright-information SuperBuild/CMake/SystemCheckup.cmake
W: otb source: file-without-copyright-information SuperBuild/CMakeLists.txt
W: otb source: file-without-copyright-information SuperBuild/CTestConfig.cmake
W: otb source: file-without-copyright-information SuperBuild/README
W: otb source: file-without-copyright-information SuperBuild/patches/BOOST/1.54.0/boost/cstdint.hpp
W: otb source: file-without-copyright-information SuperBuild/patches/BOOST/1.54.0/boost/date_time/local_time/custom_time_zone.hpp
W: otb source: file-without-copyright-information SuperBuild/patches/BOOST/1.54.0/boost/log/utility/once_block.hpp
W: otb source: file-without-copyright-information SuperBuild/patches/BOOST/1.54.0/boost/thread/win32/thread_primitives.hpp
W: otb source: file-without-copyright-information SuperBuild/patches/BOOST/1.54.0/libs/coroutine/build/Jamfile.v2
W: otb source: file-without-copyright-information SuperBuild/patches/BOOST/CMakeLists.txt
W: otb source: file-without-copyright-information SuperBuild/patches/GDAL/CMakeLists.txt
W: otb source: file-without-copyright-information SuperBuild/patches/GDAL/nmake_gdal_extra.opt.in
W: otb source: file-without-copyright-information SuperBuild/patches/GDAL/ogrsqlitevirtualogr.cpp
W: otb source: file-without-copyright-information SuperBuild/patches/GEOTIFF/CMakeLists.txt
W: otb source: file-without-copyright-information SuperBuild/patches/GEOTIFF/configure
W: otb source: file-without-copyright-information SuperBuild/patches/GLUT/CMakeLists.txt
W: otb source: file-without-copyright-information SuperBuild/patches/ITK/hashtable.hxx.in
W: otb source: file-without-copyright-information SuperBuild/patches/JPEG/CMakeLists.txt
W: otb source: file-without-copyright-information SuperBuild/patches/JPEG/configure
W: otb source: file-without-copyright-information SuperBuild/patches/LIBKML/CMakeLists.txt
W: otb source: file-without-copyright-information SuperBuild/patches/LIBKML/src/kml/base/file_posix.cc
W: otb source: file-without-copyright-information SuperBuild/patches/LIBKML/src/kml/base/util.h
W: otb source: file-without-copyright-information SuperBuild/patches/LIBSVM/CMakeLists.txt
W: otb source: file-without-copyright-information SuperBuild/patches/MUPARSER/CMakeLists.txt
W: otb source: file-without-copyright-information SuperBuild/patches/MUPARSERX/CMakeLists.txt
W: otb source: file-without-copyright-information SuperBuild/patches/OPENTHREADS/CMakeLists.txt
W: otb source: file-without-copyright-information SuperBuild/patches/OSSIM/OssimUtilities.cmake
W: otb source: file-without-copyright-information SuperBuild/patches/PROJ/CMakeLists.txt
W: otb source: file-without-copyright-information SuperBuild/patches/QT4/configure_qt4.bat.in
W: otb source: file-without-copyright-information SuperBuild/patches/QWT/qwtconfig.pri
W: otb source: file-without-copyright-information SuperBuild/patches/SQLITE/CMakeLists.txt
W: otb source: file-without-copyright-information SuperBuild/patches/SQLITE/sqlite3_win.c
W: otb source: file-without-copyright-information SuperBuild/patches/TIFF/CMakeLists.txt
W: otb source: file-without-copyright-information SuperBuild/patches/TIFF/nmake.opt
W: otb source: file-without-copyright-information SuperBuild/patches/TINYXML/CMakeLists.txt
W: otb source: missing-license-paragraph-in-dep5-copyright public domain (paragraph at line 94)
W: otb source: missing-license-paragraph-in-dep5-copyright lgpl-3 (paragraph at line 81)
W: otb source: missing-license-paragraph-in-dep5-copyright lgpl-2 (paragraph at line 75)
W: otb source: missing-license-paragraph-in-dep5-copyright apache2 (paragraph at line 86)
W: otb source: space-in-std-shortname-in-dep5-copyright public domain (paragraph at line 94)
W: otb-bin: package-name-doesnt-match-sonames libOTBCommandLine-5.0-1 libOTBCommandLineParser-5.0-1
W: otb-bin: binary-without-manpage usr/bin/otbApplicationLauncherCommandLine
W: otb-bin-qt: package-name-doesnt-match-sonames libOTBQtWidget-5.0-1
W: otb-bin-qt: binary-without-manpage usr/bin/otbApplicationLauncherQt
W: libotb: package-name-doesnt-match-sonames libOTBApplicationEngine-5.0-1 libOTBCarto-5.0-1 libOTBCommon-5.0-1 libOTBCurlAdapters-5.0-1 libOTBEdge-5.0-1 libOTBExtendedFilename-5.0-1 libOTBFuzzy-5.0-1 libOTBGdalAdapters-5.0-1 libOTBIOBSQ-5.0-1 libOTBIOGDAL-5.0-1 libOTBIOKML-5.0-1 libOTBIOLUM-5.0-1 libOTBIOMSTAR-5.0-1 libOTBIOMW-5.0-1 libOTBIOONERA-5.0-1 libOTBIORAD-5.0-1 libOTBIOTileMap-5.0-1 libOTBImageBase-5.0-1 libOTBImageIO-5.0-1 libOTBImageManipulation-5.0-1 libOTBMathParser-5.0-1 libOTBMetadata-5.0-1 libOTBOSSIMAdapters-5.0-1 libOTBOpenThreadsAdapters-5.0-1 libOTBPolarimetry-5.0-1 libOTBProjection-5.0-1 libOTBRCC8-5.0-1 libOTBStreaming-5.0-1 libOTBSupervised-5.0-1 libOTBTestKernel-5.0-1 libOTBTransform-5.0-1 libOTBVectorDataBase-5.0-1 libOTBVectorDataIO-5.0-1 libOTBWavelet-5.0-1 libotbossimplugins-5.0-1 libotbsiftfast-5.0-1
W: libotb: binary-without-manpage usr/bin/otbTestDriver
Finished running lintian.
Now signing changes and any dsc files...
signfile otb_5.0.0-1.dsc Rashad Kanavath <rashad.kanavath@c-s.fr>
gpg: skipped "Rashad Kanavath <rashad.kanavath@c-s.fr>": secret key not available
gpg: /tmp/debsign.HUyeRkK4/otb_5.0.0-1.dsc: clearsign failed: secret key not available
debsign: gpg error occurred! Aborting....
debuild: fatal error at line 1295:
running debsign failed
gbp:error: 'debuild -i -I' failed: it exited with 29

On Mon, Aug 31, 2015 at 6:42 PM, Rashad M <mohammedrashadkm@gmail.com> wrote:

Hi Johan,

On Fri, Aug 28, 2015 at 10:12 PM, Johan Van de Wauw <johan.vandewauw@gmail.com> wrote:
Hi Rashad,

Some help:

Thanks for help and sorry for my reply.

On Fri, Aug 28, 2015 at 5:22 PM, Rashad M <mohammedrashadkm@gmail.com> wrote:
>
> I did lintian check on .changes file. Below is the output
>
> lintian -I otb_5.0.0-1_amd64.changes
> W: otb source: binaries-have-file-conflict libotb otb-bin
> usr/lib/x86_64-linux-gnu/libOTBCommandLine-5.0.so.1
> W: otb source: binaries-have-file-conflict libotb otb-bin
> usr/lib/x86_64-linux-gnu/libOTBCommandLineParser-5.0.so.1
> W: otb source: binaries-have-file-conflict libotb otb-bin-qt
> usr/lib/x86_64-linux-gnu/libOTBQtWidget-5.0.so.1
> W: otb source: binaries-have-file-conflict libotb-dev otb-bin
> usr/lib/x86_64-linux-gnu/libOTBCommandLine-5.0.so
> W: otb source: binaries-have-file-conflict libotb-dev otb-bin
> usr/lib/x86_64-linux-gnu/libOTBCommandLineParser-5.0.so
> W: otb source: binaries-have-file-conflict libotb-dev otb-bin-qt
> usr/lib/x86_64-linux-gnu/libOTBQtWidget-5.0.so

This is a bad error: you can not actually install otb-bin

dpkg: error processing archive ../otb-bin_5.0.0-1_amd64.deb (--install):
trying to overwrite
'/usr/lib/x86_64-linux-gnu/libOTBCommandLine-5.0.so.1', which is also
in package libotb 5.0.0-1
dpkg-deb: error: subprocess paste was killed by signal (Broken pipe)
Errors were encountered while processing:

libOTBCommandLine should be in otb-bin as this is related to otbApplicationLauncherCommandLine. So I gues wildcard doesn't work in this case.

Can I have something like include all lib* expect libOTBCommandLine* in the libotb.install file ? If not I need to list each so manually.

Make sure that these binaries are only part of one package.

> W: otb source: changelog-should-mention-nmu
> W: otb source: source-nmu-has-incorrect-version-number 5.0.0-1
Add yourself to uploaders (d/control) and make sure the changelog is
signed by your name (set DEBEMAIL and DEBFULLNAME environment
variables).

Okay.

> I: otb source: quilt-patch-missing-description spelling.patch
> W: otb source: syntax-error-in-dep5-copyright line 621: Cannot parse line
> "GNU LESSER GENERAL PUBLIC LICENSE"
All text below "License:" should be intended one space with a dot on
empty lines.
In this case you can make life easy for yourself and refer te the full
version of the license at: /usr/share/common-licenses/LGPL-3

In this case the license text for LGPL3 in ThirdParty/SiftFast/src/LICENsE is different from one that in /usr/share/common-licenses/LGPL-3. so I added the full text. I removed those and in the comment section I mention "LICENSE and AUTHOR file in directory."

http://anonscm.debian.org/cgit/pkg-grass/otb.git/tree/debian/copyright#n80

> I: otb-bin-common: spelling-error-in-binary
>...
> I: otb-bin-common: spelling-error-in-binary
> usr/lib/otb/applications/otbapp_VectorDataReprojection.so allows to allows
> one to

I'm no fan of patching those, but you can do so if you like.Perhaps
better to report them upstream so the next release does not have these
errors.
I had discussed about this in upstream bug tracker. If possible, I will push with next release!

> W: libotb: package-name-doesnt-match-sonames libOTBApplicationEngine-5.0-1
> libOTBCarto-5.0-1 libOTBCommandLine-5.0-1 libOTBCommandLineParser-5.0-1
> libOTBCommon-5.0-1 libOTBCurlAdapters-5.0-1 libOTBEdge-5.0-1
> libOTBExtendedFilename-5.0-1 libOTBFuzzy-5.0-1 libOTBGdalAdapters-5.0-1
> libOTBIOBSQ-5.0-1 libOTBIOGDAL-5.0-1 libOTBIOKML-5.0-1 libOTBIOLUM-5.0-1
> libOTBIOMSTAR-5.0-1 libOTBIOMW-5.0-1 libOTBIOONERA-5.0-1 libOTBIORAD-5.0-1
> libOTBIOTileMap-5.0-1 libOTBImageBase-5.0-1 libOTBImageIO-5.0-1
> libOTBImageManipulation-5.0-1 libOTBMathParser-5.0-1 libOTBMetadata-5.0-1
> libOTBOSSIMAdapters-5.0-1 libOTBOpenThreadsAdapters-5.0-1
> libOTBPolarimetry-5.0-1 libOTBProjection-5.0-1 libOTBQtWidget-5.0-1
> libOTBRCC8-5.0-1 libOTBStreaming-5.0-1 libOTBSupervised-5.0-1
> libOTBTestKernel-5.0-1 libOTBTransform-5.0-1 libOTBVectorDataBase-5.0-1
> libOTBVectorDataIO-5.0-1 libOTBWavelet-5.0-1 libotbossimplugins-5.0-1
> libotbsiftfast-5.0-1

In principle, we could create a seperate package for every library.
Are there any third party software projects using only some of the
otb-libs? Otherwise I would keep them in one package especially since
updates will have a new version number in their soname.

...
> usr/lib/x86_64-linux-gnu/libOTBIORAD-5.0.so.1
General remark: I wonder if it is useful to have an sonumber (the .1)
here if the release is already part of the soname.

> W: otb-bin: binary-without-manpage usr/bin/otbApplicationLauncherCommandLine

It is ok not to have a manfile here.
Not immediately related to packaging, but I do wonder if it would not
be better to have less binaries with different names. Compare it to
git. In the early days git-commit, ... were seperate binaries. Now you
run git commit.
Perhaps it would be better to have sth like that for otb as well:
otb ApplicationLauncher

I will add a better manpage entry for each application with help2man

> W: otb-bin: non-dev-pkg-with-shlib-symlink
> usr/lib/x86_64-linux-gnu/libOTBCommandLineParser-5.0.so.1
> usr/lib/x86_64-linux-gnu/libOTBCommandLineParser-5.0.so

put the .so in your otb-lib-dev package.

> W: otb-bin: non-dev-pkg-with-shlib-symlink
> usr/lib/x86_64-linux-gnu/libOTBCommandLine-5.0.so.1
> usr/lib/x86_64-linux-gnu/libOTBCommandLine-5.0.so
> I: otb-bin: no-symbols-control-file
Are there any programs which use the OTB libraries which are not part of OTB?
If there are none, especially since OTB has the release number in the
library name I don't see any value in adding symbols.
>
> Most of them are warnings. But dont know if they can be ignored considering
> the packaging policy.

The first warnings (file conflicts) must certainly be fixed otherwise
you can not install!
The unversioned.so files should also go into the -dev package.

I will update the debian/* and let you know.

Kind Regards,
Johan

--
Regards,
Rashad

Regards,
Rashad