Re: sfcgal package for postgis and others
On 06/16/2015 11:46 AM, Sven Geggus wrote:
> Sebastiaan Couwenberg <sebastic@xs4all.nl> wrote:
>
>> You need to add the hooks when you're creating the chroot, or when you
>> want to add them to an existing chroot you need to use the --hookdir
>> option together with the --save-after-login option to store the chroot
>> changes.
>
> Hm I have been using exactly the command from the website for setting up the
> chroot:
> cowbuilder --create --distribution=sid --basepath=/var/cache/pbuilder/base-sid.cow --hookdir=~/pbuilder-hooks/
>
> No lintian gets started, when calling "gbp buildpackage --git-pbuilder"
If you did this from a root shell ~/pbuilder-hooks will be
/root/pbuilder-hooks, and not your home directory as expected.
I don't use the setup as documented in the policy myself, my pbuilder
hooks live in /var/cache/pbuilder/hooks/, but since this is not FHS
compliant I don't want to make it a recommendation. It does keep the
pbuilder stuff nicely together.
> Anyway, I think I have fixed the remaining stuff.
>
> I added an override for the fortify stuff and there are only a couple of minor
> pedantic warnings left.
lintian-wise the package looks good now.
> So if you don't dig out another showstopper for me I would give it a go now.
Showstopper is not really the word, but some improvements to the
copyright should still be made.
You can drop the extra Copyright string in debian/* Files section. The
field name is sufficient.
The copyright statements for the same author can be grouped, i.e:
Copyright: 2011, 2013, GeometryFactory (France)
If you prefer to keep the two copyright statements per author, consider
aligning the copyright to make it more readable, i.e:
Copyright: 2011, GeometryFactory (France)
2013, GeometryFactory (France)
The incomplete copyright for Triangle_2_Triangle_2_intersection_impl.h
must be fixed though.
licensecheck failed to extract the authors because they were not on the
same line as the start of the copyright:
// Copyright (c) 2000
// Utrecht University (The Netherlands),
// ETH Zurich (Switzerland),
// INRIA Sophia-Antipolis (France),
// Max-Planck-Institute Saarbruecken (Germany),
// and Tel-Aviv University (Israel). All rights reserved.
This results in the following Copyright field:
Copyright: 2000, Utrecht University (The Netherlands)
2000, ETH Zurich (Switzerland)
2000, INRIA Sophia-Antipolis (France)
2000, Max-Planck-Institute Saarbruecken (Germany)
2000, Tel-Aviv University (Israel)
The CGAL patches are all dual-licensed, both (L)GPL or commerical. The
alternative commercial license is not reflected in the debian/copyright
file yet.
The syntax for alternative licenses are documented in copyright-format
1.0, see:
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-syntax
The dual (L)GPL or Commercial licensing is common for Qt projects, these
can serve as an example. See for instance QLandkartGT:
http://anonscm.debian.org/cgit/pkg-grass/qlandkartegt.git/tree/debian/copyright
The copyright file for QLandkartGT just documents the commercial license
as it's recorded in the copyright headers of the source files.
You can do the same for sfcgal which would result in:
Files: ...
Copyright: ...
License: LGPL-3+ or CGAL-Commercial
...
License: CGAL-Commercial
Licensees holding a valid commercial license may use this file in
accordance with the commercial license agreement provided with the
software.
It's a shame that the cgal package doesn't use copyright-format 1.0 yet,
you could have copied the license from there if it were. It does
document the commercial license in a bit more detail, see:
http://sources.debian.net/src/cgal/4.6-3/debian/copyright/#L146
Adding the first and last paragraph of the upstream CGAL LICENSE as a
comment will help clarify the dual licensing. The Files section will
then become:
Files: ...
Copyright: ...
Comment: The CGAL software consists of several parts, each of which is
licensed under an open source license. It is also possible to obtain
commercial licenses from GeometryFactory (www.geometryfactory.com)
for all or parts of CGAL.
.
More information on the CGAL license can be found at
http://www.cgal.org/license.html
License: LGPL-3+ or CGAL-Commercial
> If you would have asked me 2 Weeks ago I would have said that I know how to
> build a Debian package, but now I'm not so shure anymore.
Building a Debian package is easy, you just need to know which tools to
use, where to find the reference documentation and have a general
understanding of dpkg. Building a *Policy compliant* Debian package
takes a bit more work, and more documentation to read.
Kind Regards,
Bas
--
GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
Reply to: