[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: osmpbf package



On So, Mär 16, 2014 at 11:02:24 +0100, Sebastiaan Couwenberg wrote:
> On 03/15/2014 10:10 PM, Jochen Topf wrote:
> > On Sa, Mär 15, 2014 at 10:03:44 +0100, Sebastiaan Couwenberg wrote:
> >> Thanks for the quick fix. I looked in the repo at github but don't see
> >> the changes in question but I do see the new release. The release tag
> >> only changes the version number and the ReleaseNotes.txt.
> >>
> >> I just got home from a Dutch OSM meeting, so I'll have a look at this
> >> tomorrow. I reproduced the problem on my Debian kFreeBSD VM but don't
> >> have a fix yet, so I'd love to try your changes.
> > 
> > Sorry, forgot to push...
> 
> Thanks again for the fix. With the updated build.xml in v1.3.3 the build
> still fails (on kfreebsd-amd64 and hurd-i386 at least), now with javac
> errors like:
> 
>     [javac] 1. ERROR in
> /tmp/osmpbf/src.java/crosby/binary/BinaryParser.java (at line 58)
>     [javac]     public void handleBlock(FileBlock message) {
>     [javac]                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>     [javac] The method handleBlock(FileBlock) of type BinaryParser must
> override a superclass method
> 
> This is a problem with Java 5. Classes implementing interface methods
> can be annotated with @Override in Java 6; but with Java 5 @Override can
> only be applied to methods overriding a superclass method.
> 
> Since we're stuck with Java 5 on these and other architectures as
> mentioned by Francesco, osmpbf either needs to exclude these
> architectures or be updated to support Java 5 and up.
> 
> Is supporting Java 5 and up an option for OSMPBF upstream?

My Java knowledge doesn't reach that far, that I can decide that. But frankly,
Java 6 came out more than 7 years ago. I am not willing to spend my time
supporting the 10 year old Java 5.

Jochen
-- 
Jochen Topf  jochen@remote.org  http://www.jochentopf.com/  +49-721-388298


Reply to: