Re: osmpbf package
Hi Jochen,
On 03/15/2014 10:10 PM, Jochen Topf wrote:
> On Sa, Mär 15, 2014 at 10:03:44 +0100, Sebastiaan Couwenberg wrote:
>> Thanks for the quick fix. I looked in the repo at github but don't see
>> the changes in question but I do see the new release. The release tag
>> only changes the version number and the ReleaseNotes.txt.
>>
>> I just got home from a Dutch OSM meeting, so I'll have a look at this
>> tomorrow. I reproduced the problem on my Debian kFreeBSD VM but don't
>> have a fix yet, so I'd love to try your changes.
>
> Sorry, forgot to push...
Thanks again for the fix. With the updated build.xml in v1.3.3 the build
still fails (on kfreebsd-amd64 and hurd-i386 at least), now with javac
errors like:
[javac] 1. ERROR in
/tmp/osmpbf/src.java/crosby/binary/BinaryParser.java (at line 58)
[javac] public void handleBlock(FileBlock message) {
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] The method handleBlock(FileBlock) of type BinaryParser must
override a superclass method
This is a problem with Java 5. Classes implementing interface methods
can be annotated with @Override in Java 6; but with Java 5 @Override can
only be applied to methods overriding a superclass method.
Since we're stuck with Java 5 on these and other architectures as
mentioned by Francesco, osmpbf either needs to exclude these
architectures or be updated to support Java 5 and up.
Is supporting Java 5 and up an option for OSMPBF upstream?
> Jochen
Kind Regards,
Bas
--
GPG Key ID: 4096R/E88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
dpkg-buildpackage -rfakeroot -D -us -uc -i -I -sa
dpkg-buildpackage: source package osmpbf
dpkg-buildpackage: source version 1.3.3-1
dpkg-buildpackage: source distribution UNRELEASED
dpkg-buildpackage: source changed by Bas Couwenberg <sebastic@xs4all.nl>
dpkg-source -i -I --before-build osmpbf
dpkg-buildpackage: host architecture kfreebsd-amd64
fakeroot debian/rules clean
dh clean --buildsystem makefile --parallel
dh_testdir -O--buildsystem=makefile -O--parallel
debian/rules override_dh_auto_clean
make[1]: Entering directory `/home/bas/git/pkg-grass/osmpbf'
dh_auto_clean --buildsystem ant
Buildfile: /home/bas/git/pkg-grass/osmpbf/build.xml
clean:
BUILD SUCCESSFUL
Total time: 1 second
dh_auto_clean -Dsrc
make[2]: Entering directory `/home/bas/git/pkg-grass/osmpbf/src'
rm -f *.pb.h *.pb.cc *.pb.o libosmpbf.a
make[2]: Leaving directory `/home/bas/git/pkg-grass/osmpbf/src'
dh_auto_clean -Dtools
make[2]: Entering directory `/home/bas/git/pkg-grass/osmpbf/tools'
rm -f osmpbf-outline
make[2]: Leaving directory `/home/bas/git/pkg-grass/osmpbf/tools'
mh_clean
make[1]: Leaving directory `/home/bas/git/pkg-grass/osmpbf'
dh_clean -O--buildsystem=makefile -O--parallel
dpkg-source -i -I -b osmpbf
dpkg-source: info: using source format `3.0 (quilt)'
dpkg-source: info: building osmpbf using existing ./osmpbf_1.3.3.orig.tar.gz
dpkg-source: info: building osmpbf in osmpbf_1.3.3-1.debian.tar.xz
dpkg-source: info: building osmpbf in osmpbf_1.3.3-1.dsc
debian/rules build
dh build --buildsystem makefile --parallel
dh_testdir -O--buildsystem=makefile -O--parallel
debian/rules override_dh_auto_configure
make[1]: Entering directory `/home/bas/git/pkg-grass/osmpbf'
dh_auto_configure --buildsystem ant
dh_auto_configure -Dsrc
dh_auto_configure -Dtools
make[1]: Leaving directory `/home/bas/git/pkg-grass/osmpbf'
debian/rules override_dh_auto_build
make[1]: Entering directory `/home/bas/git/pkg-grass/osmpbf'
dh_auto_build --buildsystem ant
Buildfile: /home/bas/git/pkg-grass/osmpbf/build.xml
init:
[mkdir] Created dir: /home/bas/git/pkg-grass/osmpbf/generated.java
[mkdir] Created dir: /home/bas/git/pkg-grass/osmpbf/build
build:
[javac] Compiling 16 source files to /home/bas/git/pkg-grass/osmpbf/build
[javac] ----------
[javac] 1. ERROR in /home/bas/git/pkg-grass/osmpbf/src.java/crosby/binary/BinaryParser.java (at line 58)
[javac] public void handleBlock(FileBlock message) {
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] The method handleBlock(FileBlock) of type BinaryParser must override a superclass method
[javac] ----------
[javac] 2. ERROR in /home/bas/git/pkg-grass/osmpbf/src.java/crosby/binary/BinaryParser.java
[javac] (at line 80)
[javac] public boolean skipBlock(FileBlockPosition block) {
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] The method skipBlock(FileBlockPosition) of type BinaryParser must override a superclass method
[javac] ----------
[javac] ----------
[javac] 3. ERROR in /home/bas/git/pkg-grass/osmpbf/src.java/crosby/binary/StringTable.java (at line 60)
[javac] public int compare(final String s1, String s2) {
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] The method compare(String, String) of type new Comparator<String>(){} must override a superclass method
[javac] ----------
[javac] ----------
[javac] 4. WARNING in /home/bas/git/pkg-grass/osmpbf/src.java/crosby/binary/file/FileBlock.java
[javac] (at line 77)
[javac] deflater.deflate(out, deflater.getTotalOut(), out.length
[javac] ^^^^^^^^^^^^^
[javac] The method getTotalOut() from the type Deflater is deprecated
[javac] ----------
[javac] 5. WARNING in /home/bas/git/pkg-grass/osmpbf/src.java/crosby/binary/file/FileBlock.java (at line 78)
[javac] - deflater.getTotalOut());
[javac] ^^^^^^^^^^^^^
[javac] The method getTotalOut() from the type Deflater is deprecated
[javac] ----------
[javac] 6. WARNING in /home/bas/git/pkg-grass/osmpbf/src.java/crosby/binary/file/FileBlock.java (at line 84)
[javac] .getTotalOut());
[javac] ^^^^^^^^^^^^^
[javac] The method getTotalOut() from the type Deflater is deprecated
[javac] ----------
[javac] 7. WARNING in /home/bas/git/pkg-grass/osmpbf/src.java/crosby/binary/file/FileBlock.java (at line 86)
[javac] deflater.end();
[javac] ^^^^^
[javac] The method end() from the type Deflater is deprecated
[javac] ----------
[javac] ----------
[javac] 8. WARNING in /home/bas/git/pkg-grass/osmpbf/src.java/crosby/binary/file/FileBlockPosition.java (at line 63)
[javac] decompresser.end();
[javac] ^^^^^
[javac] The method end() from the type Inflater is deprecated
[javac] ----------
[javac] ----------
[javac] 9. WARNING in /home/bas/git/pkg-grass/osmpbf/src.java/crosby/binary/test/BuildTestFile.java (at line 20)
[javac] import java.io.FileNotFoundException;
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] The import java.io.FileNotFoundException is never used
[javac] ----------
[javac] 10. WARNING in /home/bas/git/pkg-grass/osmpbf/src.java/crosby/binary/test/BuildTestFile.java (at line 23)
[javac] import java.util.Arrays;
[javac] ^^^^^^^^^^^^^^^^
[javac] The import java.util.Arrays is never used
[javac] ----------
[javac] 11. WARNING in /home/bas/git/pkg-grass/osmpbf/src.java/crosby/binary/test/BuildTestFile.java (at line 24)
[javac] import java.util.Collections;
[javac] ^^^^^^^^^^^^^^^^^^^^^
[javac] The import java.util.Collections is never used
[javac] ----------
[javac] 12. WARNING in /home/bas/git/pkg-grass/osmpbf/src.java/crosby/binary/test/BuildTestFile.java (at line 28)
[javac] import crosby.binary.Fileformat.Blob;
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] The import crosby.binary.Fileformat.Blob is never used
[javac] ----------
[javac] 13. WARNING in /home/bas/git/pkg-grass/osmpbf/src.java/crosby/binary/test/BuildTestFile.java (at line 29)
[javac] import crosby.binary.Fileformat.BlobHeader;
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] The import crosby.binary.Fileformat.BlobHeader is never used
[javac] ----------
[javac] 14. WARNING in /home/bas/git/pkg-grass/osmpbf/src.java/crosby/binary/test/BuildTestFile.java
[javac] (at line 35)
[javac] import crosby.binary.Osmformat.PrimitiveBlock.Builder;
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] The import crosby.binary.Osmformat.PrimitiveBlock.Builder is never used
[javac] ----------
[javac] ----------
[javac] 15. WARNING in /home/bas/git/pkg-grass/osmpbf/src.java/crosby/binary/test/ReadFileExample.java (at line 29)
[javac] Relation r = null;
[javac] ^
[javac] The value of the local variable r is not used
[javac] ----------
[javac] ----------
[javac] 16. WARNING in /home/bas/git/pkg-grass/osmpbf/generated.java/crosby/binary/Fileformat.java (at line 111)
[javac] private Blob(com.google.protobuf.GeneratedMessageLite.Builder builder) {
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] GeneratedMessageLite.Builder is a raw type. References to generic type GeneratedMessageLite.Builder<MessageType,BuilderType> should be parameterized
[javac] ----------
[javac] 17. WARNING in /home/bas/git/pkg-grass/osmpbf/generated.java/crosby/binary/Fileformat.java (at line 131)
[javac] int mutable_bitField0_ = 0;
[javac] ^^^^^^^^^^^^^^^^^^
[javac] The value of the local variable mutable_bitField0_ is not used
[javac] ----------
[javac] 18. WARNING in /home/bas/git/pkg-grass/osmpbf/generated.java/crosby/binary/Fileformat.java (at line 885)
[javac] private BlobHeader(com.google.protobuf.GeneratedMessageLite.Builder builder) {
[javac]
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] GeneratedMessageLite.Builder is a raw type. References to generic type GeneratedMessageLite.Builder<MessageType,BuilderType> should be parameterized
[javac] ----------
[javac] 19. WARNING in /home/bas/git/pkg-grass/osmpbf/generated.java/crosby/binary/Fileformat.java (at line 905)
[javac] int mutable_bitField0_ = 0;
[javac] ^^^^^^^^^^^^^^^^^^
[javac] The value of the local variable mutable_bitField0_ is not used
[javac] ----------
[javac] ----------
[javac] 20. WARNING in /home/bas/git/pkg-grass/osmpbf/generated.java/crosby/binary/Osmformat.java (at line 196)
[javac] private HeaderBlock(com.google.protobuf.GeneratedMessageLite.Builder builder) {
[javac]
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] GeneratedMessageLite.Builder is a raw type. References to generic type GeneratedMessageLite.Builder<MessageType,BuilderType> should be parameterized
[javac] ----------
[javac] 21. WARNING in /home/bas/git/pkg-grass/osmpbf/generated.java/crosby/binary/Osmformat.java (at line 1686)
[javac] private HeaderBBox(com.google.protobuf.GeneratedMessageLite.Builder builder) {
[javac]
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] GeneratedMessageLite.Builder is a raw type. References to generic type GeneratedMessageLite.Builder<MessageType,BuilderType> should be parameterized
[javac] ----------
[javac] 22. WARNING in /home/bas/git/pkg-grass/osmpbf/generated.java/crosby/binary/Osmformat.java (at line 1706)
[javac] int mutable_bitField0_ = 0;
[javac] ^^^^^^^^^^^^^^^^^^
[javac] The value of the local variable mutable_bitField0_ is not used
[javac] ----------
[javac] 23. WARNING in /home/bas/git/pkg-grass/osmpbf/generated.java/crosby/binary/Osmformat.java (at line 2343)
[javac] private PrimitiveBlock(com.google.protobuf.GeneratedMessageLite.Builder builder) {
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] GeneratedMessageLite.Builder is a raw type. References to generic type GeneratedMessageLite.Builder<MessageType,BuilderType> should be parameterized
[javac] ----------
[javac] 24. WARNING in /home/bas/git/pkg-grass/osmpbf/generated.java/crosby/binary/Osmformat.java (at line 3349)
[javac] private PrimitiveGroup(com.google.protobuf.GeneratedMessageLite.Builder builder) {
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] GeneratedMessageLite.Builder is a raw type. References to generic type GeneratedMessageLite.Builder<MessageType,BuilderType> should be parameterized
[javac] ----------
[javac] 25. WARNING in /home/bas/git/pkg-grass/osmpbf/generated.java/crosby/binary/Osmformat.java (at line 4569)
[javac] private StringTable(com.google.protobuf.GeneratedMessageLite.Builder builder) {
[javac]
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] GeneratedMessageLite.Builder is a raw type. References to generic type GeneratedMessageLite.Builder<MessageType,BuilderType> should be parameterized
[javac] ----------
[javac] 26. WARNING in /home/bas/git/pkg-grass/osmpbf/generated.java/crosby/binary/Osmformat.java (at line 4821)
[javac] int from_bitField0_ = bitField0_;
[javac] ^^^^^^^^^^^^^^^
[javac] The value of the local variable from_bitField0_ is not used
[javac] ----------
[javac] 27. WARNING in /home/bas/git/pkg-grass/osmpbf/generated.java/crosby/binary/Osmformat.java (at line 5055)
[javac] private Info(com.google.protobuf.GeneratedMessageLite.Builder builder) {
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] GeneratedMessageLite.Builder is a raw type. References to generic type GeneratedMessageLite.Builder<MessageType,BuilderType> should be parameterized
[javac] ----------
[javac] 28. WARNING in /home/bas/git/pkg-grass/osmpbf/generated.java/crosby/binary/Osmformat.java
[javac] (at line 5075)
[javac] int mutable_bitField0_ = 0;
[javac] ^^^^^^^^^^^^^^^^^^
[javac] The value of the local variable mutable_bitField0_ is not used
[javac] ----------
[javac] 29. WARNING in /home/bas/git/pkg-grass/osmpbf/generated.java/crosby/binary/Osmformat.java
[javac] (at line 5996)
[javac] private DenseInfo(com.google.protobuf.GeneratedMessageLite.Builder builder) {
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] GeneratedMessageLite.Builder is a raw type. References to generic type GeneratedMessageLite.Builder<MessageType,BuilderType> should be parameterized
[javac] ----------
[javac] 30. WARNING in /home/bas/git/pkg-grass/osmpbf/generated.java/crosby/binary/Osmformat.java
[javac] (at line 6706)
[javac] int from_bitField0_ = bitField0_;
[javac] ^^^^^^^^^^^^^^^
[javac] The value of the local variable from_bitField0_ is not used
[javac] ----------
[javac] 31. WARNING in /home/bas/git/pkg-grass/osmpbf/generated.java/crosby/binary/Osmformat.java
[javac] (at line 7467)
[javac] private ChangeSet(com.google.protobuf.GeneratedMessageLite.Builder builder) {
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] GeneratedMessageLite.Builder is a raw type. References to generic type GeneratedMessageLite.Builder<MessageType,BuilderType> should be parameterized
[javac] ----------
[javac] 32. WARNING in /home/bas/git/pkg-grass/osmpbf/generated.java/crosby/binary/Osmformat.java
[javac] (at line 7487)
[javac] int mutable_bitField0_ = 0;
[javac] ^^^^^^^^^^^^^^^^^^
[javac] The value of the local variable mutable_bitField0_ is not used
[javac] ----------
[javac] 33. WARNING in /home/bas/git/pkg-grass/osmpbf/generated.java/crosby/binary/Osmformat.java
[javac] (at line 7957)
[javac] private Node(com.google.protobuf.GeneratedMessageLite.Builder builder) {
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] GeneratedMessageLite.Builder is a raw type. References to generic type GeneratedMessageLite.Builder<MessageType,BuilderType> should be parameterized
[javac] ----------
[javac] 34. WARNING in /home/bas/git/pkg-grass/osmpbf/generated.java/crosby/binary/Osmformat.java
[javac] (at line 9093)
[javac] private DenseNodes(com.google.protobuf.GeneratedMessageLite.Builder builder) {
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] GeneratedMessageLite.Builder is a raw type. References to generic type GeneratedMessageLite.Builder<MessageType,BuilderType> should be parameterized
[javac] ----------
[javac] 35. WARNING in /home/bas/git/pkg-grass/osmpbf/generated.java/crosby/binary/Osmformat.java
[javac] (at line 10342)
[javac] private Way(com.google.protobuf.GeneratedMessageLite.Builder builder) {
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] GeneratedMessageLite.Builder is a raw type. References to generic type GeneratedMessageLite.Builder<MessageType,BuilderType> should be parameterized
[javac] ----------
[javac] 36. WARNING in /home/bas/git/pkg-grass/osmpbf/generated.java/crosby/binary/Osmformat.java
[javac] (at line 11445)
[javac] private Relation(com.google.protobuf.GeneratedMessageLite.Builder builder) {
[javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[javac] GeneratedMessageLite.Builder is a raw type. References to generic type GeneratedMessageLite.Builder<MessageType,BuilderType> should be parameterized
[javac] ----------
[javac] 36 problems (3 errors, 33 warnings)
BUILD FAILED
/home/bas/git/pkg-grass/osmpbf/build.xml:24: Compile failed; see the compiler error output for details.
Total time: 1 second
dh_auto_build: ant returned exit code 1
make[1]: *** [override_dh_auto_build] Error 1
make[1]: Leaving directory `/home/bas/git/pkg-grass/osmpbf'
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
debuild: fatal error at line 1364:
dpkg-buildpackage -rfakeroot -D -us -uc -i -I -sa failed
gbp:error: Couldn't run 'debuild -i -I -sa': debuild -i -I returned 25
Reply to: