[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Triggers status?



On Wed, 2007-10-24 at 22:35:23 +0100, Ian Jackson wrote:
> Raphael Hertzog writes ("Re: Triggers status?"):
> > * you replaced a bunch of "NULL" by "(char*)0". This reverts 
> >   http://git.debian.org/?p=dpkg/dpkg.git;a=commit;h=4e5846ccd3dcc33504aba8ef35a8962bccfd562e
> >   I believe you should use NULL everywhere. (My personal taste also favors
> >   NULL over "(char*)0" but it's not even a question of what I prefer since
> >   I'm not an official dpkg maintainer)
> 
> This isn't a matter of preference, I'm afraid.  I reverted this
> because the change was wrong.  NULL is incorrect in that context (a
> stdarg function expecting a char*), because it may be #define'd to 0.

That's true, but then I agree with others [0] that an environment that
defines NULL to 0 (even if the standard allows that) is not sane. Such
ancient environment will also not be able to cope with modern software
like gtk, anyway.

regards,
guillem

[0] http://lwn.net/Articles/93577/



Reply to: