[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Updating mupen64plus-qt





On Thu, Feb 20, 2020, 09:44 Dan <maintainer@hasting.email> wrote:
On 2/20/20 12:08 AM, Olek Wojnar wrote:
> Hi,
>
> On Wed, Feb 19, 2020 at 8:44 PM Dan <maintainer@hasting.email> wrote:
>
>> On 2/19/20 5:54 PM, Olek Wojnar wrote:
>>>
>>> I would not revert that commit, it is *almost* perfect as-is. Just delete
>>> the "mupen64plus-qt.png" at the end of line 3 in d/install.
>>>
>>> -Olek
>>>
>>>>
>>>
>>
>> That would leave an icon with the name "mupen64plus.png" when the icon
>> needs to be renamed to "mupen64plus-qt.png" before being installed. I don't
>> believe there's a way to this only in debian/install, which was why
>> dh_auto_install was overridden.
>>
>
> Ah, I missed the rename part. That's almost as easy though. You can just
> use dh-exec to rename the file in d/install. See the dh_install man page
> [1] for details.
>
> This is something I could change upstream by adding an icon named
>> "mupen64plus-qt.png", but that will have to be a future release.
>>
>
> That would definitely be the better long-term solution!
>
> -Olek
>
> [1] https://manpages.debian.org/unstable/debhelper/dh_install.1.en.html
>

It's changed now upstream so there's a "mupen64plus-qt.png" file to install.

I saw that, thanks!

But keep the dh-exec trick in mind if you ever need to change filenames and can't pull an upstream release. :)


Reply to: