Re: Updating mupen64plus-qt
On Tue, Feb 18, 2020, 12:33 Dan <firstname.lastname@example.org> wrote:
On 2/12/20 9:00 PM, Dan wrote:
> On 2/12/20 5:40 PM, Markus Koschany wrote:
>> Hi Dan,
>> Am 12.02.20 um 04:32 schrieb Dan:
>>> Hi Markus,
>>> There's a new version of this package I've uploaded to
>>> I've written into email@example.com a couple times
>>> the past few weeks with no responses. Wondering if you could get this
>>> reviewed/uploaded for me or point me to a good channel to contact for
>>> getting this updated.
>>> - Dan
>> Thanks, I've uploaded your new upstream version to unstable. You forgot
>> to import the new version to our upstream and pristine-tar branches
>> though, so the checksum for the orig tarball will be different from the
>> official release. Otherwise the changes looked good to me.
> Thanks for uploading! Thought I had imported those branches with gbp but perhaps I forgot to run `git push --tags`
> - Dan
I've noticed the new package produces an icon error:
On my system it's placing the icon in /usr/share/icons/hicolor/128x128/apps/mupen64plus-qt.png/mupen64plus.png (inside a directory)
Seems that's caused by this commit that was commited right before it was uploaded. It removed the cp command that prevented this issue:
What's the best way to proceed? I can revert the commit and upload a new version if needed.
I would not revert that commit, it is *almost* perfect as-is. Just delete the "mupen64plus-qt.png" at the end of line 3 in d/install.