[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PROBLEM] in 2.2.15 busybox tar



On Fri Jun 09, 2000 at 03:42:12PM -0400, Ben Collins wrote:
> >     /*
> >      * Check if we are done writing to the file now.
> >      */
> >     if (dataCc <= 0 && tostdoutFlag == FALSE) {
> >         struct utimbuf utb;
> > 
> >         if (close(outFd))
> >             perror(outName);
> > 
> >         /* Set the file time */
> >         utb.actime = mtime;
> >         utb.modtime = mtime;
> >         utime(outName, &utb);
> >         /* Set the file permissions */
> >         chown(outName, uid, gid);
> >         chmod(outName, mode);
> > 
> >         outFd = -1;
> >     }
> 
> I just commited a fix that gets rid of the utime(), chown(), and chmod()
> calls from this part of tar.c. From what I showed, the utime, mode, and
> ownership is already set once prior to this being called. Doing so again
> is pointless.

Did this fix the problem you were seeing then?

 -Erik

--
Erik B. Andersen   Web:    http://www.xmission.com/~andersen/ 
                   email:  andersee@debian.org
--This message was written using 73% post-consumer electrons--



Reply to: