[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PROBLEM] in 2.2.15 busybox tar



>     /*
>      * Check if we are done writing to the file now.
>      */
>     if (dataCc <= 0 && tostdoutFlag == FALSE) {
>         struct utimbuf utb;
> 
>         if (close(outFd))
>             perror(outName);
> 
>         /* Set the file time */
>         utb.actime = mtime;
>         utb.modtime = mtime;
>         utime(outName, &utb);
>         /* Set the file permissions */
>         chown(outName, uid, gid);
>         chmod(outName, mode);
> 
>         outFd = -1;
>     }

I just commited a fix that gets rid of the utime(), chown(), and chmod()
calls from this part of tar.c. From what I showed, the utime, mode, and
ownership is already set once prior to this being called. Doing so again
is pointless.

Ben

-- 
 -----------=======-=-======-=========-----------=====------------=-=------
/  Ben Collins  --  ...on that fantastic voyage...  --  Debian GNU/Linux   \
`  bcollins@debian.org  --  bcollins@openldap.org  --  bcollins@linux.com  '
 `---=========------=======-------------=-=-----=-===-======-------=--=---'



Reply to: