Re: [install report] 2.2.4-2000-01-03 (en) (A ToDo list)

[Taketoshi Sano <kgh12351@nifty.ne.jp>]

Sorry, I was wrong.

In article <[🔎] y5aaeloqtmp.fsf@kgh12351.nifty.ne.jp>, I wrote:

> I check boxes.c, and think that yesNoBox() returns 0 for "Yes", or -1 for "No".

This is wrong. yesNotBox() returns -1 for "Yes", or 0 for "No".

So,

> If so, then
> 
> >    if (! yesNoBox(prtbuf,_("Are You Sure?")) )
> >      return 1;
> 
> is correct ? Should we remove "!" in front of yesNoBox() here ?

This is false report. excuse me.

I think that following section remains true.

> This seems that if bootargs.isverbose == 0, then get_cflag() returns 0.
> Then, "if (! bootargs.isquiet ) {" is not enough, and this shoud be changed
> to "if (! bootargs.isquiet  && cflag) {", or "if (bootargs.isverbose && cflag) {"
> in:
> 
>   cflag = get_cflag(p->name);
>   if (! bootargs.isquiet {
>     sprintf(prtbuf,_("You have chosen to initialize %s as a Linux \"ext2\" files
> ystem. This will permanently erase any data on this partition. Are you sure you 
> want to do this?"),
>             p->name);
> 
> Pleae check this too. Thanks.

-- 
  Taketoshi Sano: <sano@debian.org>,<sano@debian.or.jp>,<kgh12351@nifty.ne.jp>