[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Hexchat 2.9.6.1-2



On Mon, Mar 10, 2014 at 8:37 PM, Jesse Rhodes <drubo@drubo.net> wrote:
> I have no idea what happened there, but I've re-uploaded and tested
> and it works now.

Ok, so here's a quick review. The debdiff has some changes that aren't
strictly necessary for a backport and it's obvious that you weren't
working off of the current hexchat packaging in jessie/sid:

diff -Nru hexchat-2.9.6.1/debian/changelog hexchat-2.9.6.1/debian/changelog
--- hexchat-2.9.6.1/debian/changelog 2014-02-25 19:59:31.000000000 -0800
+++ hexchat-2.9.6.1/debian/changelog 2014-03-09 09:31:49.000000000 -0700
@@ -1,10 +1,16 @@
-hexchat (2.9.6.1-2) unstable; urgency=low
+hexchat (2.9.6.1-2~bpo70+1) wheezy-backports; urgency=medium
+
+  * Rebuild for wheezy-backports.
+
+ -- Jesse Rhodes <drubo@drubo.net>  Tue, 25 Feb 2014 17:36:11 -0700
+
+hexchat (2.9.6.1-2) UNRELEASED; urgency=medium

   * Now using dh-autoreconf instead of autotools-dev (Closes: #739630)
   * Added gvfs-bin as Recommends so default url handlers work
     (Closes: #740006)
   * Added unifont as Suggests for unicode symbol support
-  * Included png,svg icons in package
+  * Included png,svg icons

  -- Jesse Rhodes <drubo@drubo.net>  Tue, 25 Feb 2014 16:45:42 -0700

diff -Nru hexchat-2.9.6.1/debian/control hexchat-2.9.6.1/debian/control
--- hexchat-2.9.6.1/debian/control 2014-02-25 15:45:30.000000000 -0800
+++ hexchat-2.9.6.1/debian/control 2014-02-25 16:33:39.000000000 -0800
@@ -25,9 +25,9 @@
 Package: hexchat
 Architecture: any
 Provides: irc
-Depends: ${misc:Depends}, hexchat-common (= ${source:Version}),
${shlibs:Depends}
 Recommends: gvfs-bin
 Suggests: unifont
+Depends: ${misc:Depends}, hexchat-common (= ${source:Version}),
${shlibs:Depends}
 Description: IRC client for X based on X-Chat 2
  HexChat is a graphical IRC client with a GTK+ GUI. Features include Python
  (2 and 3) and Perl scripting support, a plugin API, multiple server/channel
diff -Nru hexchat-2.9.6.1/debian/copyright hexchat-2.9.6.1/debian/copyright
--- hexchat-2.9.6.1/debian/copyright 2014-02-25 20:05:30.000000000 -0800
+++ hexchat-2.9.6.1/debian/copyright 2014-02-17 11:19:06.000000000 -0800
@@ -171,6 +171,7 @@
   0. You just DO WHAT THE FUCK YOU WANT TO.

 License: Expat
+ Copyright (c) 2010-2012 Berke Viktor
  .
  Permission is hereby granted, free of charge, to any person obtaining
  a copy of this software and associated documentation files (the


I strongly recommend that you maintain your packaging in some VCS
(svn/git), preferably hosted on Alioth (see [1]) please. That makes it
far easier for both you and me (as your sponsor) to track changes in
your packaging. I say this because this isn't the first time you've
reverted a fix or changed something in your packaging that was
previous uploaded for no reason that I can discern, and I'd rather not
have to poke you about this on every single upload.

The above changes are harmless enough that it's still fine for
wheezy-backports (however, I would've only expected a new
debian/changelog entry, with no other changes). Built, signed,
uploaded; thanks for your contribution to Debian!

Regards,
Vincent

[1] https://wiki.debian.org/Alioth/PackagingProject


Reply to: