[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Request for Rawtran packaging review



Hi Filip,

Filip Hroch <hroch@physics.muni.cz> writes:
> I updated rawtran again because the CI test didn't pass due to
> non-empty error output indicating an obsolete macro.

One point here: In the moment, the check gives no error, but it actually
checks the wrong thing: it rebuilds the rawtran executable and checks it
instead of the installed executable. 

This is not what the CI test is intended to do. Imagine f.e. if cfitsio
breaks its ABI but not the API, then the recompiled executable would
work, but the packaged one not -- and these are exactly the errors one
would like to find with the CI test.

I would just pragmatically compile the fitslint program manually (into
$ADTTMP) and run the test by hand there.

Best regards

Ole


Reply to: