[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Request for Rawtran packaging review

Hi Ole,

On Thu, 2016-04-07 at 09:37 +0200, Ole Streicher wrote:

> One point here: In the moment, the check gives no error, but it actually
> checks the wrong thing: it rebuilds the rawtran executable and checks it
> instead of the installed executable. 
> This is not what the CI test is intended to do. Imagine f.e. if cfitsio
> breaks its ABI but not the API, then the recompiled executable would
> work, but the packaged one not -- and these are exactly the errors one
> would like to find with the CI test.
> I would just pragmatically compile the fitslint program manually (into
> $ADTTMP) and run the test by hand there.

You're right. The way violated the rule:

The cwd of each test is guaranteed to be the root of the source package,
which will have been unpacked but not built. *However* note that the
tests must test the *installed* version of the program. Tests may not
modify the source tree (and may not have write access to it).

So I uploaded corrected version. Please, check it.

Thank you
F. Hroch      e-mail, jabber: hroch@physics.muni.cz, tel.: +420549494470
Dept. of theor. physics and astrophysics, MU Brno, Kotlarska 2,CZ-611 37

Reply to: