[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#845018: RFS: quagga/1.1.0-1 [ITA] -- network routing daemons



 ❦ 22 novembre 2016 23:55 +1100, Scott Leggett <scott@sl.id.au> :

> This is now ready, here are the changes since your last review:
>
> * Add automatic migration from -dbg to -dbgsym.
> * Add users/groups unconditionally to simplify preinst.
> * Create "quagga" metapackage.

I would have removed the recommends for quagga-core package as it would
make more difficult for most people to only keep the daemons they need
and do not bring anything sensible compared to quagga/quagga-core
packages. Of course, that's quite subjective.

> * Use debhelper integration with dpkg-maintscript-helper.
> * Remove /etc/default/quagga.

Should be removed with dpkg-maintscript-helper to alert the user there
was a change (and its modifications are now ignored).

You could also remove README.Maintainer if it doesn't contain any
relevant information. There are also some bits of the README.Debian
about SNMP that are not up-to-date (some sentences just need to be
removed).

Other than that, all is OK.
-- 
Debian package sponsoring guidelines:
 https://vincent.bernat.im/en/debian-package-sponsoring.html

Attachment: signature.asc
Description: PGP signature


Reply to: