[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#845018: RFS: quagga/1.1.0-1 [ITA] -- network routing daemons



 ❦ 22 novembre 2016 23:55 +1100, Scott Leggett <scott@sl.id.au> :

>> dh_installinit should install it if you name it quagga-core.default.
>
> Instead I have just removed /etc/default/quagga from the package because
> it wasn't much use anymore.

You need to use dpkg-maintscript-helper rm_conffile to tell the user
about this change.

>> >>  - the service files seem to use wrong paths. In Debian, chown is in
>> >>    /bin, not /usr/bin.
>> >> 
>> >
>> > This is interesting.. I ran `which chmod` on my unstable test box, and
>> > got "/usr/bin/chmod". /bin is a symlink to /usr/bin in unstable now, and
>> > /usr/bin is before /bin in $PATH.
>> 
>> It's because you have installed usrmerge. I don't think this is like
>> this on a standard installation.
>>
>
> I don't have usrmerge installed.. this is a fresh unstable install from
> a netboot mini.iso.

I think usrmerge was enabled for a moment. This was reverted recently.

> This is now ready, here are the changes since your last review:
>
> * Add automatic migration from -dbg to -dbgsym.
> * Add users/groups unconditionally to simplify preinst.
> * Create "quagga" metapackage.
> * Remove informational lintian overrides.
> * Rename quagga-dev package to libquagga-dev.
> * Remove non-standard maintainer script debugging code.
> * Fix paths in .service file patch.
> * Use dpkg-statoverride in preference to manual chmod/chown.
> * Add Vcs-* fields to control file.
> * Update quagga.NEWS.
> * Update changelog for 1.1.0-1 release
> * Use debhelper integration with dpkg-maintscript-helper.
> * Remove /etc/default/quagga.

OK, I'll take a look.
-- 
Debian package sponsoring guidelines:
 https://vincent.bernat.im/en/debian-package-sponsoring.html

Attachment: signature.asc
Description: PGP signature


Reply to: