❦ 20 novembre 2016 01:43 +1100, Scott Leggett <scott@sl.id.au> : > * Rely on automatic -dbgsym package rather than deprecated -dbg. You need to make a migration for people having a -dbg. This is done with --dbgsym-migration argument of dh_strip. > * Add quagga user to quaggavty group in preinst. I suppose this was in the original packaging, but this is better to use adduser/addgroup unconditionally. Both commands will check if the user/group already exists with the appropriate parameters. Notably, if the user/group is not a system one, it will trigger an error. > * Use systemd .service files rather than init.d scripts (Closes: #678946, > #805840, #839819, #412483). I am quite OK with that. You don't have time to sort out those problems. However, this is somewhat controversial. > * Split quagga package out into multiple packages (Closes: #705306). People upgrading will suddenly have all the daemons missing. You could introduce a "base" or "minimal" package that wouldn't depend on the daemons (and the daemons would depend on them). The "quagga" package would still depend on all the daemons. However, the NEWS entry could be sufficient too. Also : - the -dev package should be libquagga-dev - default/quagga could be called "quagga.default" and would be installed automatically as /etc/default/quagga. - the service files seem to use wrong paths. In Debian, chown is in /bin, not /usr/bin. - if you think that maintaining all those lintian overrides is too much effort, I think that people usually don't override "informational" messages. - in maintainers script, I would drop the non-standard debug stuff at the top of each of them - in postinst, changing permissions in /etc is frowned upon since it could undo what a user has done. You should use dpkg-statoverride which gives the user a chance to implement its own policy. -- Debian package sponsoring guidelines: https://vincent.bernat.im/en/debian-package-sponsoring.html
Attachment:
signature.asc
Description: PGP signature