On 2016-11-21.13:56, Vincent Bernat wrote: > ❦ 21 novembre 2016 23:39 +1100, Scott Leggett <scott@sl.id.au> : > > >> > * Use systemd .service files rather than init.d scripts (Closes: #678946, > >> > #805840, #839819, #412483). > >> > >> I am quite OK with that. You don't have time to sort out those > >> problems. However, this is somewhat controversial. > >> > > > > I'm open to accepting patches / co-maintainership from anyone who wishes > > to test and use traditional init scripts with quagga. Given the > > longevity of bugs like #678946, I'm not optimistic of such patches > > materialising. > > > > I personally cannot test such init scripts since all my systems now use > > systemd, and I can't in good faith include code that I can't test and > > which has known bugs. > > > > If there is another approach you think I could take here, please > > advise... > > People who want other people to keep init scripts alive are asking to > just leave them be, even if they are buggy. That's not something I agree > with, so I am happy that you just removed them. But you could get some > opposition. > That's okay. I'm happy to work with anyone who wants to improve the quagga package. > >> - default/quagga could be called "quagga.default" and would be > >> installed automatically as /etc/default/quagga. > >> > > > > As this is now part of "quagga-core", I still have to install this > > file manually as far as I can tell. Thanks for the tip on the debhelper > > way to install it though. > > dh_installinit should install it if you name it quagga-core.default. > Instead I have just removed /etc/default/quagga from the package because it wasn't much use anymore. > >> - the service files seem to use wrong paths. In Debian, chown is in > >> /bin, not /usr/bin. > >> > > > > This is interesting.. I ran `which chmod` on my unstable test box, and > > got "/usr/bin/chmod". /bin is a symlink to /usr/bin in unstable now, and > > /usr/bin is before /bin in $PATH. > > It's because you have installed usrmerge. I don't think this is like > this on a standard installation. > I don't have usrmerge installed.. this is a fresh unstable install from a netboot mini.iso. > > The new package is available again at > > https://mentors.debian.net/package/quagga > > I'll review the changes for tomorrow. This is now ready, here are the changes since your last review: * Add automatic migration from -dbg to -dbgsym. * Add users/groups unconditionally to simplify preinst. * Create "quagga" metapackage. * Remove informational lintian overrides. * Rename quagga-dev package to libquagga-dev. * Remove non-standard maintainer script debugging code. * Fix paths in .service file patch. * Use dpkg-statoverride in preference to manual chmod/chown. * Add Vcs-* fields to control file. * Update quagga.NEWS. * Update changelog for 1.1.0-1 release * Use debhelper integration with dpkg-maintscript-helper. * Remove /etc/default/quagga. -- Regards, Scott.
Attachment:
signature.asc
Description: Digital signature