Bug#827982: RFS: libstroke/0.5.1-7 [QA, RC] -- mouse strokes library
* Sean Whitton <spwhitton@spwhitton.name>, 2016-06-23, 23:36:
https://mentors.debian.net/debian/pool/main/libs/libstroke/libstroke_0.5.1-7.dsc
Looks pretty good to me.
Just a few minor points:
+ * Bump debhelper compat to 5 (Closes: #817554).
There's still "debhelper (>= 4)" in Build-Depends.
It's not a problem in practice, because debhelper (>= 5) is available
even in oldoldoldoldstable, but the pedant in me is slightly bothered.
+ * Fix calling ldconfig trigger:
Sounds odd. s/calling/generating/ maybe?
+build-arch: build
+build-indep: build
There are no architecture-independent packages, so it would be more
natural to have build-indep do nothing. But then binary-indep is not a
no-op either. Meh, let's leave it as is. This debian/rules is a mess
anyway.
+ # empties dependency_libs from .la file
+ # http://lists.debian.org/debian-devel/2009/08/msg00783.html
+ sed -i "s,^dependency_libs=.*,dependency_libs=''," $(CURDIR)/debian/libstroke0-dev/usr/lib/libstroke.la
I recommend against using $(CURDIR) if possible, as it causes
unnecessary noise in build logs. Here you could use a relative path.
--
Jakub Wilk
Reply to: