Hello, On Thu, Jun 23, 2016 at 08:03:24PM +0500, Andrey Rahmatullin wrote: > Maybe you run lintian aginst .deb? You should run it against .changes. No excuse, unfortunately for me -- I was running it against the .changes, if my understanding of /usr/bin/perl5/Sbuild/Build.pm is correct. On Thu, Jun 23, 2016 at 07:40:56PM +0200, Jakub Wilk wrote: > * Sean Whitton <spwhitton@spwhitton.name>, 2016-06-23, 23:36: > > > > https://mentors.debian.net/debian/pool/main/libs/libstroke/libstroke_0.5.1-7.dsc > > Looks pretty good to me. > Just a few minor points: > > > + * Bump debhelper compat to 5 (Closes: #817554). > > There's still "debhelper (>= 4)" in Build-Depends. > It's not a problem in practice, because debhelper (>= 5) is available even > in oldoldoldoldstable, but the pedant in me is slightly bothered. I always forget that! > > + * Fix calling ldconfig trigger: > > Sounds odd. s/calling/generating/ maybe? Hmm. I changed it to "Fix ldconfig trigger." > > +build-arch: build +build-indep: build > > There are no architecture-independent packages, so it would be more natural > to have build-indep do nothing. But then binary-indep is not a no-op either. > Meh, let's leave it as is. This debian/rules is a mess anyway. That's what I was thinking. > > + # empties dependency_libs from .la file + # > > http://lists.debian.org/debian-devel/2009/08/msg00783.html + sed -i > > "s,^dependency_libs=.*,dependency_libs=''," > > $(CURDIR)/debian/libstroke0-dev/usr/lib/libstroke.la > > I recommend against using $(CURDIR) if possible, as it causes unnecessary > noise in build logs. Here you could use a relative path. I changed it, but could you explain the problem with $(CURDIR)? I wasn't aware of the noise problem. Re-uploaded to mentors. -- Sean Whitton
Attachment:
signature.asc
Description: PGP signature