Hello, Thank you for taking the time to look at my upload. On Thu, Jun 23, 2016 at 03:58:13PM +0200, Jakub Wilk wrote: > * Sean Whitton <spwhitton@spwhitton.name>, 2016-06-23, 22:22: > > > > * Replace libstroke0.postinst with ldconfig trigger in > > > > libstroke0.triggers. > > > You shouldn't need this file; dh_makeshlibs is supposed to register > > > the trigger automatically. > > It doesn't, > > Hmm, indeed. > > > for some reason :) > > The order of dh_ commands in debian/rules is b0rked. > dh_installdeb should be called after dh_makeshlibs. > > NB, this is detected by Lintian: > W: libstroke source: debian-rules-calls-debhelper-in-odd-order dh_makeshlibs (line 74) Not sure how I missed that from Lintian -- thanks. > > https://mentors.debian.net/debian/pool/main/libs/libstroke/libstroke_0.5.1-7.dsc > > I understand that you don't want to spend too much time on polishing the > package, but I'd like these Lintian warnings fixed: > > W: libstroke source: configure-generated-file-in-source config.log > (this was introduced in -7) Whoops, again, I should have caught that. > W: libstroke source: debian-rules-missing-recommended-target > build-indep W: libstroke source: > debian-rules-missing-recommended-target build-arch (this is violation > of a "must" policy) Done. Let's hope #657390 gets fixed soon. > W: libstroke source: debhelper-but-no-misc-depends libstroke0 W: > libstroke source: debhelper-but-no-misc-depends libstroke0-dev Done. I re-uploaded to mentors after verifying debdiff, piuparts and fvwm build again. -- Sean Whitton
Attachment:
signature.asc
Description: PGP signature