[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#798458: RFS: mini-httpd/1.21-1 [ITA] -- Small HTTP server



 ❦ 14 septembre 2015 11:49 -0300, J.S.Júnior <j.s.junior@live.com> :

> Send for mentor with new changes.

OK, this looks good to me. However, your debian/changelog has many
English errors and is sometimes difficult to read. I propose to apply
the following patch to fix that. If you are OK with the patch, I can
upload.

diff --git a/debian/changelog b/debian/changelog
index 5379434b9076..653a42ece37e 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,39 +1,35 @@
 mini-httpd (1.21-1) unstable; urgency=medium
 
   * New upstream release.
-  * New Maintainer.(Closes: #780194)
+  * New maintainer. (Closes: #780194)
   * Fix CVE-2015-1548 
-      patch fix-add_to_response-buffer-overflow. (Closes: #778925)
+      - Patch fix-add_to_response-buffer-overflow. (Closes: #778925)
   * d/control:
-      - Bumped Standart-Version to 3.9.6
-      - Bumped debhelper to 9
-      - Remove deprecated dpatch upgrade packaging 
-	    format "3.0 (quilt)". (Closes: #664363)
+      - Bump Standard-Version to 3.9.6.
+      - Bump debhelper to 9.
+      - Remove deprecated dpatch.
+      - Upgrade packaging format "3.0 (quilt)". (Closes: #664363)
       - Remove article in description synopsis.
-      - Changed depends
+      - Add ${misc:Depends}.
   * d/copyright
-      - Updated format dep5.
-      - Formating copyright.
+      - Update to DEP5 format.
+      - Formatting copyright.
   * d/rules:
-      - Clean and upgrade rules for simple.
-      - Added Changelog upstream extracted of website mini-httpd
+      - Upgrade to dh sequencer.
+      - Added upstream changelog extracted from mini-httpd website.
   * d/mini-httpd.init.d:
-      - Fix error restart (Closes: #510905, #755892)
+      - Fix restart error. (Closes: #510905, #755892)
   * d/patches:
-      - Fixe and added SCRIPT_FILENAME in patch 03-cgi-php (Close: #569599)
-      - Hardening for minit_httpd.c and to function.
-      - Remove install htpasswd.1
-      - Added index.mini-httpd.html for find mini-httpd
+      - Fix and add SCRIPT_FILENAME in patch 03-cgi-php. (Closes: #569599)
+      - Ensure hardening is enabled for mini_httpd.c.
+      - Don't install htpasswd.1.
+      - Add index.mini-httpd.html to the list of index names.
   * d/mini-httpd.init.d
-       - Add . /lib/lsb/init-functions in script
-       - Add options status in script 
-  * d/mini-httpd.postinstall
-      - Changed the default document root, for var/www/html in postinstall
-	    and rename index for index.mini-httpd.html in 
-	    fix-change-index-document-root. (Closes: #730373)
-    - Fix error set -e and no install htpasswd (Closes: #520941)
-    - Added post instal for default root copy index.html to var/www/html
-	  Thanks Sr.Vicent Bernat
+      - Source /lib/lsb/init-functions.
+      - Add "status" command.
+  * d/mini-httpd.postinst
+      - Copy index.mini-httpd.html. (Closes: #730373)
+      - Use "set -e" and don't install htpasswd. (Closes: #520941)
 
  -- Jose dos Santos Junior <j.s.junior@live.com>  Thu, 03 Sep 2015 14:59:53 -0300
 
diff --git a/debian/patches/fix-add_to_response-buffer-overflow b/debian/patches/fix-add_to_response-buffer-overflow
index 8ebd0e93c846..33c90ac9528a 100644
--- a/debian/patches/fix-add_to_response-buffer-overflow
+++ b/debian/patches/fix-add_to_response-buffer-overflow
@@ -1,6 +1,6 @@
 Description: Fix buffer overflow in add_to_response bug Thanks Peter Kasza
 Author: Jose dos Santos Junior <j.s.junior@live.com>
-Last-Update: 2015-09-02Index: mini-httpd-1.21/mini_httpd.c
+Last-Update: 2015-09-02
 Bug: http://bugs.debian.org/778925
 ===================================================================
 Index: mini-httpd-1.21/mini_httpd.c
diff --git a/debian/patches/fix-append-portno-to-vhost b/debian/patches/fix-append-portno-to-vhost
index 58e6c0ad473c..13e4df616b92 100644
--- a/debian/patches/fix-append-portno-to-vhost
+++ b/debian/patches/fix-append-portno-to-vhost
@@ -2,7 +2,7 @@ Description: Append port number to vhost.
 	       Thanks Steffen Grunewald <steffen.grunewald@gmx.net>
 Author: Jose dos Santos Junior <j.s.junior@live.com>
 Last-Update:2015-09-05
-Bug: http://bugs.debian.org/491078Index: mini-httpd-1.21/mini_httpd.c
+Bug: http://bugs.debian.org/491078
 ===================================================================
 Index: mini-httpd-1.21/mini_httpd.c
 ===================================================================
diff --git a/debian/patches/fix-change-index-document-root b/debian/patches/fix-change-index-document-root
index 6865870319a7..4ba29adcf503 100644
--- a/debian/patches/fix-change-index-document-root
+++ b/debian/patches/fix-change-index-document-root
@@ -2,7 +2,7 @@ Description: Change the default document root to /var/www/html
 	    and added index.mini-httpd.html in /var/www/html
 Author: Jose dos Santos Junior <j.s.junior@live.com>
 Last-Update: 2015-09-14
-Bug: http://bugs.debian.org/730373Index: mini-httpd-1.21/mini_httpd.c
+Bug: http://bugs.debian.org/730373
 ===================================================================
 Index: mini-httpd-1.21/mini_httpd.c
 ===================================================================
diff --git a/debian/patches/fix-makefile b/debian/patches/fix-makefile
index be0fdce96788..17a8d60d369f 100644
--- a/debian/patches/fix-makefile
+++ b/debian/patches/fix-makefile
@@ -1,6 +1,6 @@
 Description: Change DESTDIR and LCFLAGS
 Autor: Jose dos Santos Junior <j.s.junior@live.com>
-Last-Update: 2015-09-05Index: mini-httpd-1.21/Makefile
+Last-Update: 2015-09-05
 ===================================================================
 Index: mini-httpd-1.21/Makefile
 ===================================================================
-- 
Debian package sponsoring guidelines:
 http://vincent.bernat.im/en/debian-package-sponsoring.html

Attachment: signature.asc
Description: PGP signature


Reply to: