[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#798458: RFS: mini-httpd/1.21-1 [ITA] -- Small HTTP server



 ❦ 10 septembre 2015 10:41 -0300, J.S.Júnior <j.s.junior@live.com> :

>> Also, the use of 'index.mini-httpd.html' don't allow mini-httpd to find
>> it. The index names do not seem configurable. Therefore, you will need
>> to patch mini-httpd to also search for index.mini-httpd.html (after
>> index.html).
>
> I am a born programmer, but I think it iso. if you can help me thank you :)
>
> Create patch for find index.mini-httpd.html
>
> Send mentors again - ok

Sorry for the bikeshed, but some of the patch names and descriptions are
quite vague. fix-mini-httpd and fix-mini-httpd-vhost don't tell much
what they do from their names.

The description of fix-mini-httpd-vhost could be "Append port number to
vhost". The name of the patch could be "append-portno-to-vhost.patch". A
bug report number to know why this is done would be great to. Also, this
would make the Debian package behaves differently than upstream. Has
this patch been pushed upstream?

The description of fix-mini-httpd could be "Fix buffer overflow in
add_to_response". The name of the patch could be
"add_to_response-buffer-overflow.patch". The stuff about indexes should
be moved out to a different patch: when your patch is applied upstream,
you may discard it and forget about this part.

Please, keep the bug report in copy as it is the one place to go to see
what has already been told about this package.
-- 
Debian package sponsoring guidelines:
 http://vincent.bernat.im/en/debian-package-sponsoring.html

Attachment: signature.asc
Description: PGP signature


Reply to: