[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#798458: RFS: mini-httpd/1.21-1 [ITA] -- Small HTTP server



 ❦  9 septembre 2015 11:23 -0300, J.S.Júnior <j.s.junior@live.com> :

>   Changes since the last upload:
[...]

In d/copyright, you have the same clause for "*" and for "match.c" (and
others).

In d/mini-httpd.default, I would suggest to remove this "start daemon"
variable, unless most users won't start the daemon (but since you
changed the default, I suppose that most users will run the
daemon). Enabling/disabling a daemon should be done through the
appropriate init interface (eg systemctl disable mini-httpd).

In d/mini-httpd.install, you install files in /var/www/html. You should
not do that as another package could use it (which is likely not to be
the case, but you get the idea). It seems that the rule is to copy the
index.html from /usr/share/... to /var/ww/html/index.mini-httpd.html. I
don't know if this is a written policy somewhere.

>       - Fix error set -e and no install htpasswd (Closes: #520941)

Didn't look at the bug, but set -e is usually considered a bad idea in
an init script. For example, stuff like that wouldn't work (but you
don't have such a case in your init.d script, so you may ignore that):

#v+
do_start
case "$?" in
 ...
esac
#v-

The htpasswd manual page is still present.

Otherwise, looks OK to me.
-- 
Debian package sponsoring guidelines:
 http://vincent.bernat.im/en/debian-package-sponsoring.html

Attachment: signature.asc
Description: PGP signature


Reply to: