[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#798458: RFS: mini-httpd/1.21-1 [ITA] -- Small HTTP server



Em Fri, 11 Sep 2015 08:24:41 +0200
Vincent Bernat <bernat@debian.org> escreveu:

> Sorry for the bikeshed,
I don't understand this. (bikeshed) :)

> but some of the patch names and descriptions are
> quite vague. fix-mini-httpd and fix-mini-httpd-vhost don't tell much
> what they do from their names.
Yes, thanks.
I am very grateful for teaching me the proper way.

fixed

> 
> The description of fix-mini-httpd-vhost could be "Append port number to
> vhost". The name of the patch could be "append-portno-to-vhost.patch". A
> bug report number to know why this is done would be great to.
fix name.
Yes, look [1]

> Also, this
> would make the Debian package behaves differently than upstream. Has
> this patch been pushed upstream?
No, patch suggestion bug number #491078 [1]
> 
> The description of fix-mini-httpd could be "Fix buffer overflow in
> add_to_response". The name of the patch could be
> "add_to_response-buffer-overflow.patch". The stuff about indexes should
> be moved out to a different patch: when your patch is applied upstream,
> you may discard it and forget about this part.
> 
Ok, fix name.
Yes, when the upstream fix in tarball original I'm remove patch.
thanks

> Please, keep the bug report in copy as it is the one place to go to see
> what has already been told about this package.

Sorry, fault of attention.

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=491078

mentors send again - ok

Thanks again, for your patience

Cheers,
JJ

Attachment: pgpuBG2LWZsQf.pgp
Description: Assinatura digital OpenPGP


Reply to: