[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#754463: RFS: pdf2htmlex/0.11+ds-1



* Johannes Schauer <j.schauer@email.de>, 2014-07-26, 12:37:
upstream responded and I updated their name with the one they told me.

Perhaps also update patch headers?

I used the (fairly incomplete) testsuite of pdf2htmlEX to run a DEP-8 test.

The DEP-8 tests fail here. I see lots of errors like this:

Error: Cannot open file /home/jwilk/pdf2htmlex-0.11+ds/share/base.min.css for embedding
Command return code 1: /usr/bin/pdf2htmlEX --data-dir /home/jwilk/pdf2htmlex-0.11+ds/share --dest-dir /tmp/tmpTajvy6 /home/jwilk/pdf2htmlex-0.11+ds/test/test_data/2-pages.pdf

I suppose you shouldn't pass --data-dir when testing the installed version.

I don't think the patch description is grammatically correct. I believe that instead of “Allow to control …”, it should be “Allow us to control …” or “Allow controlling …”.

--
Jakub Wilk


Reply to: