[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#754463: RFS: pdf2htmlex/0.11+ds-1



* Johannes Schauer <j.schauer@email.de>, 2014-07-16, 08:36:
Note that currently uscan would generate .orig.tar with wrong version; see bug #753772.

I can confirm that I was missing a uversionmangle in my debian/watch. This is fixed now.

Now --download-current-version is broken:

$ uscan --download-current-version --destdir .
uscan warning: In debian/watch no matching hrefs for version 0.11 in watch line
 https://github.com/coolwanglu/pdf2htmlEX/releases .*/v(\d[\d\.]*)\.tar\.gz

It think you need to drop dversionmangle to fix it.

If that is all, then all then I only need somebody to sponsor this :)

Do you mean _me_? It's been less than a weak, I haven't even warmed up yet. ;-P

I noticed that when you run pdf2htmlEX for the first time, ~/.FontForge/ gets created. This is not itself a problem (even though personally I hate dotfiles with passion). The problem is that it will also happen at build time, thanks to the test suite. Creating dotfiles at build time is a no-no. I guess the simplest way to fix it is to set HOME to something non-existent in debian/rules.

I think it would be good to add a comment to d/copyright explaining that upstream clarified the license; or maybe cherry pick the commit:
https://github.com/coolwanglu/pdf2htmlEX/commit/6e8d5396cdad
Currently it might be not obvious to a person who didn't read this RFS thread (such as ftp-master) that your copyright matches upstream intentions.

I see you have lots of patches. Which of them are upstreamable? Which of them have been already forwarded? You can answer the questions by adding appropriate Forwarded: headers to the patches. :-)

--
Jakub Wilk


Reply to: