[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#754463: RFS: pdf2htmlex/0.11+ds-1



* Johannes Schauer <j.schauer@email.de>, 2014-07-13, 22:23:
If you look at the upstream repository you'll see a Debian directory

Oops, I missed it.
(Wouldn't it make sense to remove it from .orig.tar?)

uscan does this automatically when repacking upstream tarballs.

I don't believe this is the case. And the .orig.tar you uploaded to mentors certainly contains debian/:

$ tar -tf pdf2htmlex_0.11+ds.orig.tar.gz --wildcards '*/debian'
pdf2htmlEX-0.11+ds/debian/
pdf2htmlEX-0.11+ds/debian/changelog
pdf2htmlEX-0.11+ds/debian/source/
pdf2htmlEX-0.11+ds/debian/source/format
pdf2htmlEX-0.11+ds/debian/rules
pdf2htmlEX-0.11+ds/debian/pdf2htmlex.NEWS
pdf2htmlEX-0.11+ds/debian/dirs
pdf2htmlEX-0.11+ds/debian/copyright
pdf2htmlEX-0.11+ds/debian/pdf2htmlex.README
pdf2htmlEX-0.11+ds/debian/compat
pdf2htmlEX-0.11+ds/debian/pdf2htmlex.TODO
pdf2htmlEX-0.11+ds/debian/control

Removing useless linking against libpython2.7.so.1.0 was easily fixed by not build depending on python-dev.

Hmm, that doesn't sound right. It means that a user building in a non-minimal environment can get a package with or without libpython2.7-dev in Depends, depending on which packages they had installed. I think I prefer to live with the dpkg-shlibdeps warnings, than to have this sort of non-determinism.

Right. So how about a Build-Conflict with the appropriate binary package?

I tend to think of Build-Conflicts as a weapon of last resort.

I don't want to uselessly increase the amount of dependencies of the resulting binary package (even though libpython is probably present on most systems).

It wouldn't increase the amount of packages required to run pdf2htmlex, at least not for the time being, because libfontforge depends on libpython.

The reason linking to unneeded libraries is bad is because it makes Packages a tiny bit bigger, makes dependency resolved a tiny bit slower, and becomes burdensome when one of the libraries change SONAME.

Though on the other hand it seems I managed to patch the build system such that it will not use libpython anymore (see patch "no-libpython").

That's much better. Now, can you do the same with gunicode? :-)

What is your opinion about the tarball repacking and the Files-Excluded in debian/copyright?

I don't like it, but I'm not going to stop anybody from using it.
Note that currently uscan would generate .orig.tar with wrong version; see bug #753772.

--
Jakub Wilk


Reply to: