[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#754463: RFS: pdf2htmlex/0.11+ds-1



Hi,

Quoting Jakub Wilk (2014-07-12 11:50:39)
> It would guard against the possibility of losing source.
> 
> But it could still happen that compatibility.js and compatibility.min.js 
> versions (in /usr/share/pdf2htmlEX/) don't match.

okay. Indeed that's undesirable.

> Is the non-minified version used by pdf2htmlEX at runtime at all? I think it
> isn't, but I could be wrong. If it's not, then maybe get rid of the symlink,
> and drop libjs-pdf from Depends?

Yes it is. You can check that it is used by running the test suite like this:
`( cd obj-*-linux-gnu; ctest -V; )`. You will see that it aborts because it
cannot find compatibility.min.js in ./share. You have to run the test suite
like that because it wrongly shows success even though the tests fail. I'll
have to fix that and report it upstream.

The file share/manifest or /usr/share/pdf2htmlEX/manifest controls what gets
included into the final pdf. It is the "@compatibility.min.js" line in that
file which makes compatibility.min.js be included by the function
HTMLRenderer::embed_file in src/HTMLRenderer/general.cc.

compatibility.js is optional though. It is only useful for compatibility with
older browsers. This even if not the minified version, I'd like to include
compatibility.js in the output.

> I don't think it worked:
> dpkg-genchanges: warning: unknown information field 'Built-Using' in input data in general section of control info file
> 
> Built-Using should be used in the binary stanza, not in the source 
> stanza. Please see Policy §7.8.

whoops. Sorry.

I removed the Built-Using because while it retains the original source, it will
not fix the version skew :/

I guess I use the unminified version of compatibility.js until bug#754533 is
resolved.

> Not quite. AIUI, the problem is that uscan expects that filenamemangle will
> strip directory components from the filename. The uscan manpage suggests
> using
> 
> filenamemangle=s/(?:.*)?v?(\d[\d\.]*)\.tar\.gz/<project>-$1.tar.gz/
> 
> which strip them (note ".*"), but your filenamemangle wouldn't.

oooh - indeed that makes more sense now.

Thanks a ton for all your very constructive and helpful advice :)

cheers, josch


Reply to: