Bug#754463: RFS: pdf2htmlex/0.11+ds-1
* Johannes Schauer <j.schauer@email.de>, 2014-07-11, 21:33:
How did you find them? I ran codespell but that didnt find the ones you
found.
I read carefully the source code. :-) (I admit that vim's spell checking
helped me a bit.)
I'm unsure how I should handle the minified js. Surely it is desirable
to include the minified js in the output pdf2htmlex generates
Probably, but is it worth the trouble? The non-minified version is only
8 kilobytes bigger. That's negligible overhead, IMHO.
but that means that pdf2htmlex has to ship a minified version of
compatibility.js from the libjs-pdf package.
Hmm, there is no protection against the two versions getting of sync.
Which means that there is no guarantee that we are shipping source for
the minified version. :(
Should the minified version not be shipped by libjs-pdf instead? What
is the right way to do this?
I see a few ways to go forward:
1) Stop worrying and love the bomb^Wunminified JS.
2) Ask pdf.js maintainers to provide compatibility.min.js, and wait
patiently until they implement it (or not).
3) Keep minifying compatibility.js yourself, but use Built-Using to
ensure we always have the source.
I wouldn't say “In contrast to other converters …” in the package
description. It sounds a bit like an advertisement. And it means that
changes in other packages could make your package description
inadequate.
Priority should be probably "optional".
Section should be "text" or maybe "graphics"; probably not "misc".
In debian/rules you have this:
( cd logo; ./update_png.sh; )
You don't need parentheses here. You should use && between the
statements (see Policy §4.6).
dh_clean deletes all files listed in debian/clean. If you took advantage
of this, you wouldn't need to override dh_auto_clean.
The watch file doesn't work here:
$ uscan --destdir . --force-download
pdf2htmlex: Version (0.11) available on remote site:
https://github.com/coolwanglu/pdf2htmlEX/archive/v0.11.tar.gz
(local version is 0.11+ds, mangled local version number 0.11)
Could not read .//coolwanglu/pdf2htmlEX/archive/pdf2htmlEX-0.11.tar.gz: No such file or directory at /usr/bin/mk-origtargz line 310.
uscan: error: mk-origtargz --package pdf2htmlex --version 0.11 --compression gzip --directory . --copyright-file debian/copyright .//coolwanglu/pdf2htmlEX/archive/pdf2htmlEX-0.11.tar.gz gave error exit status 2
--
Jakub Wilk
Reply to: