Bug#754463: RFS: pdf2htmlex/0.11+ds-1
Hi,
wow, thanks a lot for looking into this! :D
Quoting Jakub Wilk (2014-07-11 20:59:44)
> fix-spelling seems to be mainly about fixing the use "-" as minus sign in
> manpage... Could split the patch into two, one for hyphens, another for
> actual spelling mistakes?
okay. Done.
> More typos I found:
>
> contributers -> contributors
> actualy -> actually
> positionig -> positioning
> cosider -> consider
> tempory -> temporary
> deconstructign -> deconstructing
> matices -> matrices
> new_line_stauts -> new_line_status
> Someting -> something
> natrual -> natural
> negaive -> negative
> othere -> other
> optimzation -> optimization
> cannnot -> cannot
> Inactiviy -> Inactivity
> calulating -> calculating
> lanauges -> languages
> costy -> costly
How did you find them? I ran codespell but that didnt find the ones you found.
The ones you found are now fixed in the packaging.
> What is ./debian/pdf2htmlex.README for?
That should've been pdf2htmlex.docs. Fixed.
> Is debian/dirs really needed? It should be normally job for upstream build
> system to create the directories it needs.
It is not needed. Removed, thanks!
> adequate says:
> pdf2htmlex: broken-symlink /usr/share/pdf2htmlEX/compatibility.js -> ../javascript/pdf/compatibility.js
I fixed that too. The dependency on libjs-pdf was missing.
I'm unsure how I should handle the minified js. Surely it is desirable to
include the minified js in the output pdf2htmlex generates but that means that
pdf2htmlex has to ship a minified version of compatibility.js from the
libjs-pdf package. Should the minified version not be shipped by libjs-pdf
instead? What is the right way to do this?
Thanks!
cheers, josch
Reply to: