Re: [Nbd] Proposal to merge WRITE_ZEROES extension into master

[Wouter Verhelst <w@...112...>]

On Tue, Dec 20, 2016 at 09:20:58AM +0000, Alex Bligh wrote:
> > On 20 Dec 2016, at 08:25, Wouter Verhelst <w@...112...> wrote:
> > 
> > diff --git a/nbd-server.c b/nbd-server.c
> > index cbe7e57..45cb591 100644
> > --- a/nbd-server.c
> > +++ b/nbd-server.c
> > @@ -2025,7 +2025,7 @@ static void handle_write_zeroes(CLIENT* client, struct nbd_request* req) {
> >        // TODO: handle this far more efficiently with reference to the
> >        // actual backing driver
> >        pthread_mutex_lock(&(client->lock));
> > -       writeit(client->net, &rep, sizeof rep);
> > +       socket_write(client, &rep, sizeof rep);
> >        pthread_mutex_unlock(&(client->lock));
> > }
> > 
> > I'm going to have to do a 3.15.1 for that, otherwise WRITE_ZEROES
> > handling will be broken with TLS enabled.
> 
> Sorry, that was me I think (possibly or possibly not in addition
> to Eric). Must have come from a merge error / thinko.

Yeah, no worries. I'll take care of it.

-- 
< ron> I mean, the main *practical* problem with C++, is there's like a dozen
       people in the world who think they really understand all of its rules,
       and pretty much all of them are just lying to themselves too.
 -- #debian-devel, OFTC, 2016-02-12