[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Nbd] Proposal to merge WRITE_ZEROES extension into master



> On 20 Dec 2016, at 08:25, Wouter Verhelst <w@...112...> wrote:
> 
> diff --git a/nbd-server.c b/nbd-server.c
> index cbe7e57..45cb591 100644
> --- a/nbd-server.c
> +++ b/nbd-server.c
> @@ -2025,7 +2025,7 @@ static void handle_write_zeroes(CLIENT* client, struct nbd_request* req) {
>        // TODO: handle this far more efficiently with reference to the
>        // actual backing driver
>        pthread_mutex_lock(&(client->lock));
> -       writeit(client->net, &rep, sizeof rep);
> +       socket_write(client, &rep, sizeof rep);
>        pthread_mutex_unlock(&(client->lock));
> }
> 
> I'm going to have to do a 3.15.1 for that, otherwise WRITE_ZEROES
> handling will be broken with TLS enabled.

Sorry, that was me I think (possibly or possibly not in addition
to Eric). Must have come from a merge error / thinko.

-- 
Alex Bligh







Reply to: