Re: [Nbd] Proposal to merge WRITE_ZEROES extension into master

[Wouter Verhelst <w@...112...>]

On Thu, Dec 15, 2016 at 09:45:14AM +0000, Alex Bligh wrote:
> > -	len = strlen(client->server->servename);
> > -	writeit(commsocket, &len, sizeof len);
> > -	writeit(commsocket, client->server->servename, len);
> > -	readit(commsocket, &acl, 1);
> > -	close(commsocket);
> > +	if (dontfork) {
> > +		acl = 'Y';
> > +	} else {
> > +		len = strlen(client->server->servename);
> > +		writeit(commsocket, &len, sizeof len);
> > +		writeit(commsocket, client->server->servename, len);
> > +		readit(commsocket, &acl, 1);
> > +		close(commsocket);
> > +	}
> > 
> > 	switch(acl) {
> > 		case 'N':
> > 
> 
> I don't understand this bit of the patch. This seems to disable
> acls if 'dontfork' is enabled, and also change where socket
> closing is done. There may well be a reason for this, but
> it doesn't seem to be anything to do with writezeroes.
> 
> What's going on here?

This is due to the fix for
<https://github.com/NetworkBlockDevice/nbd/issues/41>, which I applied
on master, but which breaks -d behaviour. I was meaning to fix that
still before releasing nbd 3.15, but hadn't gotten around to it yet.

Eric's patch makes -d work again, but disables maxconnections in that
case. I'll need to fix it up; hopefully that'll happen sometime next
week, because otherwise I'll be too late to make the Debian freeze for
stretch, and I'd really like STARTTLS to be in there.

Regards,

-- 
< ron> I mean, the main *practical* problem with C++, is there's like a dozen
       people in the world who think they really understand all of its rules,
       and pretty much all of them are just lying to themselves too.
 -- #debian-devel, OFTC, 2016-02-12