On Mon, Mar 7, 2011 at 20:39, Steve Langasek <vorlon@debian.org> wrote:
> Oh man, I can't believe I missed FullName(), that's kind of an obvious
> function, isn't it. :) Do you want me to change the patch to use this? The
No need to, i just manual-merged your patch (bzr errored out on the
try to merge¹) and committed my changes after that as attached.
Nothing fancy, just replaced the handmade Name() + ":" + Arch() with
FullName() and new[] with strdup as it reduces the linecount a bit.
Hope that makes it clear what i meant with FullName() usage.
We could possibly replace the complete if-else with FullName, but then
we would have to strdup for all packages and not just the multiarch ones,
so that bit of duplication is good as it is. :)
Best regards
David Kalnischkies
¹ bzr: ERROR: Revision is not compatible with
KnitPackRepository('file:///…/apt/.bzr/repository/')
… Whatever: too late and too lazy to check that now …
Attachment:
apt-fullname-and-strdup
Description: Binary data