On Mon, Mar 07, 2011 at 07:08:19PM +0100, David Kalnischkies wrote: > On Sun, Mar 6, 2011 at 05:39, Steve Langasek <vorlon@debian.org> wrote: > > Please find attached a tentative patch for this issue. It's not exactly the > > most elegant, but it seemed to be the best we can do without changing the > > libapt ABI. If you prefer a different solution, please let me know and I > > can give it a try. > Sry for not looking at it earlier myself. > I am still quiet busy with carnival duties and exams… Don't worry about it! It was a nice learning experience in apt internals for me :) > Anyway, fine for now beside that i would use I->Pkg.FullName() instead > of the handmade Name:Arch. Returns also only a std::string… Oh man, I can't believe I missed FullName(), that's kind of an obvious function, isn't it. :) Do you want me to change the patch to use this? The current patch has the advantage of caching the result of _config->Find(), and since as you say it returns std::string, we still need to take care of memory management for our C strings. So for me I don't see a clear advantage either way, and I'm happy to write it in whatever form you prefer it for inclusion. -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer http://www.debian.org/ slangasek@ubuntu.com vorlon@debian.org
Attachment:
signature.asc
Description: Digital signature