On Mon, Mar 07, 2011 at 11:33:12PM +0100, David Kalnischkies wrote:
> On Mon, Mar 7, 2011 at 20:39, Steve Langasek <vorlon@debian.org> wrote:
> > Oh man, I can't believe I missed FullName(), that's kind of an obvious
> > function, isn't it. :) Do you want me to change the patch to use this? The
> No need to, i just manual-merged your patch (bzr errored out on the
> try to merge¹) and committed my changes after that as attached.
> Nothing fancy, just replaced the handmade Name() + ":" + Arch() with
> FullName() and new[] with strdup as it reduces the linecount a bit.
Great, thanks!
> Hope that makes it clear what i meant with FullName() usage.
> We could possibly replace the complete if-else with FullName, but then
> we would have to strdup for all packages and not just the multiarch ones,
> so that bit of duplication is good as it is. :)
Yep, clear.
> ¹ bzr: ERROR: Revision is not compatible with
> KnitPackRepository('file:///…/apt/.bzr/repository/')
> … Whatever: too late and too lazy to check that now …
Ah; KnitPack is an old bzr repository format. Assuming your dev environment
is upgraded to squeeze, you should definitely run 'bzr upgrade' on any local
branches you have, as well as on
<bzr+ssh://bzr.debian.org/bzr/apt/debian-sid/>, to get the much-improved 2a
format. That will bring speed improvements when accessing the repo, and
make everyone happy. :)
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
slangasek@ubuntu.com vorlon@debian.org
Attachment:
signature.asc
Description: Digital signature