[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: use of .transignore



Peter Karlsson <peter@softwolves.pp.se> (28/05/2005):
> Jens Seidel:
> 
> >Please note that check_trans.pl still complains about file which are 
> >non-English originals such as german/consultants/jurgen_l.wml.
> 
> Hmm, I thought that was fixed.

It was fixed, but only for the files in international/

> >Is this wanted?
> 
> No, the idea is that it should check if the english file has a pointer
> back to the language version if the language version does not contain
> a translation-check header. It should only complain if both the files
> lack the header (i.e both are marked originals).

The patch attached should fix the problem (please check it to be sure
that I haven't missed anything). But it doesn't complain if both files
are marked originals.

About .transignore, do you agree with all my remarks? I think it is
important to fix these files, to serve as an example. Indeed, even if my
first feeling about how to use it was right, I spent a lot of time trying
to check if I was not wrong due to these files.

-- 
Thomas Huriaux
Index: check_trans.pl
===================================================================
RCS file: /cvs/webwml/webwml/check_trans.pl,v
retrieving revision 1.61
diff -u -r1.61 check_trans.pl
--- check_trans.pl	8 Aug 2004 14:51:44 -0000	1.61
+++ check_trans.pl	29 May 2005 10:55:00 -0000
@@ -498,9 +498,9 @@
 	}
 	my $transcheck = Webwml::TransCheck->new($name);
 	$oldr = $transcheck->revision() || 0;
-	if (!$oldr && ($name =~ m#$langto/international/$langto#i)) {
+	if (!$oldr) {
 		#   This document is original, check for
-		#   english/international/$langto...
+		#   english/...
 		$name =~ s{^$to}{$from};
 		$transcheck = Webwml::TransCheck->new($name);
 		$oldr       = $transcheck->revision() || 0;

Attachment: pgpbPiomWtYMK.pgp
Description: PGP signature


Reply to: