On 07-01-13 07:20, Graham Inggs wrote: > On 6 January 2013 16:44, Paul Gevers <elbrus@debian.org > <mailto:elbrus@debian.org>> wrote: > > [ Graham, should I drop direct e-mail to you, i.e. do you receive the > mail via the PTS anyway? ] > > > I'm receiving bug mail via the PTS for openmotif, but I don't think for > this (695130) bug. Right, I forgot this bug is a wnpp bug, and not an openmotif bug. > - My fix [3] for "format not a string literal and no format arguments" > is slightly different for sprintf cases. Shouldn't it be better to > replace the sprintf by a simple strcpy? > > > I don't mind. I suppose the only reason to stay with sprintf would be > one of style. > If upstream decided to make MSG__0113 (referred to in the first change > in line 267 of lib/Mrm/Mrmhier.c) more informative by changing "Could > not open buffer - UID version mismatch" to "Could not open buffer - UID > version mismatch (%d)" then they would have to use sprintf instead of > strcpy. I completely agree, as that is what I did to start with, but after a discussion with a programmer friend, also agree with the "abuse" of sprintf for mere string copying. I don't mind leaving your patch as is, but I do appreciate a note in the upstream bug tracker. But I can add that myself. > Do you need me to upload the above changes to my PPA? No, I rather have it that you (just) commit the changes to the Alioth git repository, and I will pull from there. I got a note that you now have access. > I would like you to do the git push of the 2.3.4 stuff. Do you want to > wait until you have access to collab-maint, or do you want me to commit > your changes, and contribute my changes as well? > > > Please go ahead and commit my changes as well as any others as you see fit. You have access yourself now, could you please try yourself? I don't mind doing it, but I like to see you handle this as well. If done properly, it is the easiest way for work together. You can make an Ubuntu branch (probably naming it after the current Ubuntu branch) if you like as well, branching at the right locations. Just make sure your commits regarding changelogs are correct. Paul
Attachment:
signature.asc
Description: OpenPGP digital signature